-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wilsonsfh iP #640
Open
wilsonsfh
wants to merge
45
commits into
nus-cs2103-AY2425S2:master
Choose a base branch
from
wilsonsfh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
wilsonsfh iP #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
Merge branch-Level-8
Merge packages edit done on branch-Level-8
add OOP
merge Level-7, features of Level-8, A-Packages, A-MoreOOP present
Add gradle-support
Add Checkstyle to master
Merge Level 10 from branch-Level-10
Add assertions with SLAP
Current situation: The application currently sorts all tasks by date or description in a single command. Why it needs to change: Users need a way to view only tasks of a specific type (todo, deadline, event) in sorted order, rather than sorting all tasks together. What is being done about it: Introduce a 'sort \<type\> \<option\>' command that filters tasks by the chosen type and sorts them in ascending (1) or descending (2) order. Ensure the main tasks remain unchanged by sorting only the filtered subset. Why it is done that way: This approach allows more granular control while reusing the existing comparator logic, keeping the implementation consistent and maintaining backward compatibility. Any other relevant info: This feature complements the existing 'sort 1'/'sort 2' commands, so users can still sort all tasks if they prefer.
Merge C-Sort to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caviar
Do you know? Fish can
drownsuffocate if there is not enough oxygen in the water. (source)Make sure to always supply oxygen into your lives as if you are a fish even among the water,
All you need to do is,
And it is FREE!
Features: