-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NaelAnoob] iP #617
Open
NaelAnoob
wants to merge
64
commits into
nus-cs2103-AY2425S2:master
Choose a base branch
from
NaelAnoob:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[NaelAnoob] iP #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
…nore writing to jackbit.txt
I realized that if I put it in .gitignore then it wouldn't be pushed to github
…mentation too much)
…very non-trivial private method
# Conflicts: # src/main/java/jackbit/tasklist/TaskList.java # src/main/java/jackbit/ui/Ui.java
# Conflicts: # src/main/java/jackbit/task/Task.java
Some commands read by Parser may not have the correct syntax, so some assertions were added to check for that.
Unnecessary newlines increase the length of the method, so I deleted them. No other glaring Code quality issues were found, but I may have overlooked them.
A-CodeQuality: Reduce length of method by taking away newlines
* 'master' of https://github.com/NaelAnoob/ip: A-CodeQuality: Reduce length of method by taking away newlines
A-Assertions: Add some assertions to Parser
* 'master' of https://github.com/NaelAnoob/ip: A-Assertions: Add some assertions to Parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jackbit: The Jack of All Tasks 🎭
Meet Jackbit, your clown-savvy task manager who’s here to turn your chaos into order! 🎪 Whether you’re juggling deadlines, balancing events, or just trying to remember to buy milk, Jackbit’s got the tricks to keep you on track.
Why Jackbit?
Jackbit isn’t just a task manager—it’s your ringmaster for productivity. Whether you’re a student, a professional, or just someone who loves a bit of fun, Jackbit makes task management simple, fast, and entertaining.
It’s:
All you need to do is:
.jar
file is saved. Then run:Let Jackbit juggle your tasks for you 🎭
And the best part? It’s FREE! 🎉
Features:
Task Juggling ✨:
Add Todos, Deadlines, and Events with a snap of your fingers.
Mark tasks as done or unmark them if you’re not ready to let go.
Delete tasks you no longer need—poof, they’re gone!
Stay in the Circus ✨:
List all your tasks in one big top.
Save the Show ✨:
Your tasks are saved automatically, so the show always goes on.
Reload your tasks the next time you start Jackbit—no rehearsals needed!
Reminders: Get a clown horn alert for upcoming deadlines and events. (Coming soon!!)
Priority Levels: Assign clown hats to your tasks for better organization. 🎩 (Coming soon!!)
Search Functionality: Find tasks faster than a clown can pull a rabbit out of a hat. 🐇 (Coming soon!!)
Jackbit greets you with a quirky ASCII art and a playful message.
It’s like having a circus in your terminal! 🎪🤹♂️
So, what are you waiting for? Download Jackbit today and let it handle your tasks while you focus on stealing the show! 🎭💥