[Caleb Cherng Kai Zhe] iP #468

Ditzchann · 2025-02-06T06:34:43Z

Angela

Hello X. I am Angela, your advisor and secretary.

Based on Project Moon's Lobotomy Corporation, Angela is an advanced ~~human~~ AI whose role is to guide you through your tasks just as she did in LC.

With the chat bot, you can enjoy

the ability to organize your tasks your tasks in one place
your tasks all saved in your local storage to come back to anytime
customized dialogue with the head AI of Lobotomy Corp, tailored for any LC fan to enjoy

Features:

Saving your tasks into your local storage
Searching for tasks
Deleting tasks

Todo (with priority!)

Command class to simplify functions
GUI

If you want to contribute, open a pull request to help improve my code! (My poor processDb function needs help 😭)

public Task processDb(String line) throws AngelaException {
        Task t;
        String[] lineArr = line.split("\\|\\|"); //no way malicious injection is real
        t = switch (lineArr[0]) { //as we all know nothing bad ever happens when we save data as text
            case "T" -> new ToDoTask(lineArr[2]);
            case "D" -> new DeadlineTask(lineArr[2], lineArr[3]);
            case "E" -> new EventTask(lineArr[2], lineArr[3], lineArr[4]);
            default -> throw new AngelaException("");
        };
        if (lineArr[1].equals("1")) t.doTask();
        return t;
    }

In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.

Added default greet function Added exit function

Added echo function to repeat user input

Added Processor.java to assist in text processing Added functionality to store inputs as a list and output them accumulatively

Created initialization for Task class Added toString() method for Task class Added ability to set tasks as done

Updated Task.java to be able to mark tasks as done Added markDone() and markUndone() to Processor.java

Added EventTask.java Fixed some formatting errors

Added processing for DeadlineTask, TodoTask and EventTask

RT0118

Other than a few nits, LGTM!

RT0118 · 2025-02-08T03:47:48Z

src/main/java/DeadlineTask.java

+
+	@Override
+	public String toString() {
+		return "[D]" + super.toString()  + " (by: " + by + ")";


I like the use of newlines to keep char count below 120

RT0118 · 2025-02-08T03:50:53Z

src/main/java/Processor.java

+import java.util.regex.Pattern;
+
+public class Processor {
+	private List<Task> store = new ArrayList<>();


Suggested change

private List<Task> store = new ArrayList<>();

private List<Task> store = new ArrayList<>();

Should this be named more specific?

RT0118 · 2025-02-08T03:56:01Z

src/main/java/Angela.java

+import java.util.Scanner;
+import java.util.List;


Suggested change

import java.util.Scanner;

import java.util.List;

import java.util.List;

import java.util.Scanner;

Perhaps your imports could be ordered lexicographically?

nikingoda

Overall, your code is easy to read and understand. However, there are still spaces to improve.
Good job!

nikingoda · 2025-02-09T14:34:41Z

src/main/java/Processor.java

+		String input;
+		do {
+			input = textIn.nextLine();
+			if (input.equalsIgnoreCase("list")) {


Maybe you can use switch-case style to improve readability and maintainability in future

nikingoda · 2025-02-09T14:39:17Z

src/main/java/Processor.java

+		output(out.trim(), true);
+	}
+
+	public void addTask(String input) {


maybe addTask(Task task) be better instead of 3 versions of addTask() for Event, Deadline and Todo, to avoid misusing

nikingoda · 2025-02-09T14:41:03Z

src/main/java/Processor.java

+			input = textIn.nextLine();
+			if (input.equalsIgnoreCase("list")) {
+				printList();
+			} else if (input.length() >= 4 && input.substring(0, 4).equalsIgnoreCase("mark")) { //probably move this in the future


you may use split(" ") to make an array String[] for convenience

SomneelSaha2004

LGTM!
There a are a few minor refactorings that are non essential.

SomneelSaha2004 · 2025-02-10T11:52:14Z

src/main/java/Angela.java

The order of imports could be lexicographical?

SomneelSaha2004 · 2025-02-10T11:56:59Z

src/main/java/Processor.java

A switch case would be easier to follow in term of logic inside the start() function.
We can use .split() to get the different parts of the input?
Then once we get the command we continue to process based off of expected format.
Since the list of tasks is of type Task we can modify addTask to have signature addTask(Task t) as then we can add all 3 types without having to write 3 different methods.

SomneelSaha2004 · 2025-02-10T11:59:06Z

src/main/java/Processor.java

We can use the java string package to more efficiently process input?
The .trim() and .split() method could remove the need for the trimInput functions

SomneelSaha2004 · 2025-02-10T12:00:16Z

src/main/java/Task.java

We can make this class abstract, as we wont be instantiating any objects of type Task and we can prevent misuse of this class and enforce usage of the actual 3 types we expect.

Output messages can be concatenated into a class and called using its static methods to prevent code duplication

Cleaned up command processing by adding new function to split command input Used switch-case instead of if-else to polish code

More abstraction in the Processor class

Add testcases to input.txt and EXPECTED.TXT Modify runtest.bat

Add several Exceptions to handle cases of invalid input

Add ability to delete tasks that are made

Add getArguments method to ensure correct argument flags are passed in

Storage.java manages the storage of the tasks into local files. Edit Processor.java to integrate changes from Storage.java

Branch level 7

Branch level 8

Add Command.java class to act as data structure for commands

Add Parser.java and TaskManager.java to handle command parsing and editing the task list

Branch a more oop

Add method to find tasks by keyword

Fix coding standard issues

Add JavaDoc

Branch level 10

Add lastFunction local variable to Angela.java Let's create a variable that stores the last inputted command that was called by the user for use in the undo function. This allows for the undo method to recall the last function used and act accordingly in the future. Add new undo() method to Angela.java The method will recall the last function, calling an undo method in the manager if the last function made changes to the database. In the event of a bad undo (undoing a list, find command), the method will give an error message.

Task class modifications Task class and its subclasses are not effectively final. This caused problems when archiving the previous iteration of the task list. Let's change do/undo task methods to return a new copy of the task, allowing for easier archiving for the tasks. Add support for archiving task list in TaskManager Lets let TaskManager save a copy of the previous iteration of tasks before any changes to the tasklist such that it can be easily retrieved to undo the change.

Add assertions to Angela.java and Storage.java

Improve code quality

Add support for undoing commands

Event Tasks were saved in the wrong format

damithc and others added 12 commits July 11, 2024 16:52

Add Gradle support

68c58c1

Bump gradle and lib version

03523ec

Level-0

c992a62

Added default greet function Added exit function

Level-1

2a747ae

Added echo function to repeat user input

Level-2

d5cf849

Added Processor.java to assist in text processing Added functionality to store inputs as a list and output them accumulatively

Created Task.java for task representation

b5d8ce9

Created initialization for Task class Added toString() method for Task class Added ability to set tasks as done

Added ability to do and undo tasks to Processor.java

d163085

Updated Task.java to be able to mark tasks as done Added markDone() and markUndone() to Processor.java

Added DeadlineTask.java and Task.java

7a54a91

Added EventTask.java

c42d330

Added EventTask.java Fixed some formatting errors

Added trimInput function to help process functions

ca37fd1

Added support for multiple tasks types

f5781b0

Added processing for DeadlineTask, TodoTask and EventTask

RT0118 reviewed Feb 8, 2025

View reviewed changes

nikingoda reviewed Feb 9, 2025

View reviewed changes

SomneelSaha2004 reviewed Feb 10, 2025

View reviewed changes

Ditzchann added 15 commits February 16, 2025 14:50

Add Output.java class

7ccca79

Output messages can be concatenated into a class and called using its static methods to prevent code duplication

Update Processor.java

4858699

Cleaned up command processing by adding new function to split command input Used switch-case instead of if-else to polish code

Use Output.java class in Processor

9b29200

More abstraction in the Processor class

Edit text-ui-test

0e6d049

Add testcases to input.txt and EXPECTED.TXT Modify runtest.bat

Add AngelaException.java

fae29d5

Add several Exceptions to handle cases of invalid input

Add delete() method to Processor.java

35d01b8

Add ability to delete tasks that are made

Add getArguments method

c9c235e

Add getArguments method to ensure correct argument flags are passed in

Add Storage.java

68727be

Storage.java manages the storage of the tasks into local files. Edit Processor.java to integrate changes from Storage.java

Merge pull request #2 from Ditzchann/branch-Level-7

17bdc6c

Branch level 7

Add ParseTime() method to Task.java

e66bf2f

Add support for dates in DD-MM-YYYY format

fdb1049

Merge pull request #3 from Ditzchann/branch-Level-8

f0fa6dd

Branch level 8

Add Command.java class

68b733d

Add Command.java class to act as data structure for commands

Reorganise code in Processor into other classes

850ffc2

Add Parser.java and TaskManager.java to handle command parsing and editing the task list

Merge pull request #4 from Ditzchann/branch-A-MoreOOP

52fcc49

Branch a more oop

Ditzchann added 30 commits February 20, 2025 23:57

Add test for Parser.java and Command.java

a00d925

Update build.gradle for making JAR file

cf2a2e7

Add JavaDoc

bedccdf

Fix coding standard issues

645b274

Add method to find tasks by keyword

4e6062b

Merge pull request #7 from Ditzchann/branch-Level-9

39c8e7e

Add method to find tasks by keyword

Merge branch 'master' into A-CodingStandard

f6ea6cc

Merge pull request #8 from Ditzchann/A-CodingStandard

08a0b37

Fix coding standard issues

Merge branch 'master' into A-JavaDoc

475e5ce

Merge pull request #9 from Ditzchann/A-JavaDoc

3b0b079

Add JavaDoc

Update JavaDoc in TaskManager.java

096ff17

Fix checkstyle errors

5cc85fa

Remove Processor.java

d4326ab

Add basic support for GUI

f064f06

Rename methods

e66f955

Merge pull request #10 from Ditzchann/branch-level-10

50e415b

Branch level 10

Add assertions to Angela.java and Storage.java

95b2b89

Add comments and fix code quality issues

a8eb249

Merge pull request #11 from Ditzchann/branch-A-Assertions

0726744

Add assertions to Angela.java and Storage.java

Merge branch 'master' into branch-A-CodeQuality

9cd75f2

Merge pull request #12 from Ditzchann/branch-A-CodeQuality

77d02c2

Improve code quality

Merge branch 'master' into branch-BCD-Extension

3f6415c

Merge branch 'master' into branch-BCD-Extension

777fb7f

Merge pull request #13 from Ditzchann/branch-BCD-Extension

443d6ae

Add support for undoing commands

Fix minor bug

12711eb

Event Tasks were saved in the wrong format

Add attribution

880455a

Add user guide and Ui screenshot

518eb92

Update README.md

d66cb7b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Caleb Cherng Kai Zhe] iP #468

[Caleb Cherng Kai Zhe] iP #468

Ditzchann commented Feb 6, 2025 •

edited

Loading

RT0118 left a comment

RT0118 Feb 8, 2025

RT0118 Feb 8, 2025

RT0118 Feb 8, 2025

nikingoda left a comment

nikingoda Feb 9, 2025

nikingoda Feb 9, 2025

nikingoda Feb 9, 2025

SomneelSaha2004 left a comment

SomneelSaha2004 Feb 10, 2025

SomneelSaha2004 Feb 10, 2025

SomneelSaha2004 Feb 10, 2025

SomneelSaha2004 Feb 10, 2025

	private List<Task> store = new ArrayList<>();
	private List<Task> store = new ArrayList<>();

[Caleb Cherng Kai Zhe] iP #468

Are you sure you want to change the base?

[Caleb Cherng Kai Zhe] iP #468

Conversation

Ditzchann commented Feb 6, 2025 • edited Loading

Angela

RT0118 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikingoda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SomneelSaha2004 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ditzchann commented Feb 6, 2025 •

edited

Loading