Mustafa Abbas iP #467

mistyk786 · 2025-02-06T05:07:32Z

🚀 Cortana – Your AI Task Manager

"Wake up, Chief. I need you." – Cortana

Cortana is your AI-powered personal assistant that helps you manage tasks seamlessly. It's:

📝 Text-based
🎓 Easy to learn
⚡ FAST – SUPER FAST to use

✨ Getting Started

📥 Download Cortana (link)
🖱️ Double-click it to run
✅ Add your tasks
🤖 Let Cortana handle them for you!

And best of all… it's FREE! 🎉

📌 Features

✅ Task management made easy
📅 Deadline tracking (coming soon)
🔔 Smart reminders (coming soon)

Task Capabilities

🗂️ Supports 3 types of tasks:
- ✅ Todo
- 📅 Deadline
- 📆 Event
💾 Auto-saves task lists
✏️ Modify tasks (mark/unmark/delete)
🔍 Search tasks using keywords

🖥️ Java Programmers, Here's the Entry Point

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.

KimHan01

Overall, i think you have several coding standard violations that you may want to address, and you may consider breaking your Main class up into different classes to handle specific logic like a Parser class to handle making sense of user input and a Response/Ui class to handle printing out messages

KimHan01 · 2025-02-06T16:14:12Z

src/main/java/Carol.java

+        out.println(INTRO_MSG);
+        list = loadTasks();
+        BufferedReader br = new BufferedReader(new InputStreamReader(System.in));
+        boolean running = true;


Perhaps its might be better to use "isRunning" instead

KimHan01 · 2025-02-06T16:15:58Z

src/main/java/Carol.java

@@ -0,0 +1,259 @@
+import java.io.*;


Imported classes should be listed explicity

KimHan01 · 2025-02-06T16:25:49Z

src/main/java/Carol.java

+            String eventTimeStart = eventStartString.split(" ")[1];
+            String eventDateEnd = eventEndString.split(" ")[0];
+            String eventTimeEnd = eventEndString.split(" ")[1];
+            Event ev = new Event(eventMessage, LocalDate.parse(eventDateStart), LocalDate.parse(eventDateEnd), LocalTime.parse(eventTimeStart), LocalTime.parse(eventTimeEnd));


Line length should be no longer than 120 chars, you could try to bring some arguments into the next line

KimHan01 · 2025-02-06T17:00:21Z

src/main/java/Task.java

+                return null;
+        }
+
+    }


A suggestion i have is to allow each Task class (Todo, Deadline, Event) to handle the logic of parsing for their specific task type.

jensenhuangyankai · 2025-02-09T10:27:28Z

src/main/java/carol/io/EventParser.java

+            DateTimeFormatter.ofPattern("hh:mm a")    // 12-hour format with AM/PM (05:30 PM)
+    };
+
+    public static Task parseTaskFromFile(String line) throws CarolException {


Though the purpose of the function is clear, DocStrings are still required for every function

jensenhuangyankai · 2025-02-09T10:28:46Z

src/main/java/carol/io/Ui.java

+             Hello! I'm Carol, your personal assistant.
+             What can I do for you?
+            """;
+    protected final String END_MSG = " Bye! Hope to hear from you soon!\n";


good that you used SCREAMING_SNAKE_CASE to define your constants

jensenhuangyankai · 2025-02-09T10:29:31Z

src/main/java/carol/io/Ui.java

+        System.out.println(message);
+    }
+
+    public static void line() {


This function needs a better name. Consider using printLine instead

jensenhuangyankai · 2025-02-09T10:33:31Z

src/main/java/carol/io/EventParser.java

+import java.time.format.DateTimeParseException;
+
+public class EventParser {
+    private static final DateTimeFormatter[] DATE_FORMATS = {


Consider not using an array for this. Makes code extremely hard to read, as you have to reference what DATE_FORMATS[0] is every time you see it. Maybe do a yyyyMMddFormatter as a name instead.

nikingoda · 2025-02-09T14:51:44Z

src/main/java/tasks/Task.java

+    }
+
+    public void markAsDone() {
+        if (!isDone) {


maybe just isDone = true; is enough

nikingoda · 2025-02-09T14:53:43Z

src/main/java/tasks/ToDo.java

+package tasks;
+
+public class ToDo extends Task{
+    private String type;


String type is not so necessary, or you may change it to final field for safe.

nikingoda · 2025-02-09T14:54:53Z

src/main/java/tasks/Event.java

+import java.time.LocalTime;
+
+public class Event extends Task {
+    private String type;


make String type to be final could be better

nikingoda · 2025-02-09T14:57:24Z

src/main/java/io/EventParser.java

+            switch (taskType) {
+            case "T":
+                ToDo todo = new ToDo(description);
+                if (isDone) {


Should provide another constructor Todo(String description, Boolean isDone)

nikingoda · 2025-02-09T14:58:05Z

src/main/java/io/EventParser.java

+                LocalTime time = LocalTime.parse(deadlineString, TIME_FORMATS[0]);
+                Deadline deadline = new Deadline(description, date, time);
+                if (isDone) {
+                    deadline.markAsDone();


Should provide another constructor Deadline(String description, LocalDate date, LocalTime time, Boolean isDone)

nikingoda · 2025-02-09T14:58:29Z

src/main/java/io/EventParser.java

+                LocalTime eventTimeEnd = LocalTime.parse(eventEndParts[1]);
+
+                Event event = new Event(description, eventDateStart, eventDateEnd, eventTimeStart, eventTimeEnd);
+                if (isDone) {


Same with deadline and event.

Loading tasks from storage leads to incorrect isDone value being returned Format of LocalDate and LocalTime Strings in Deadline and Event instances is not standardised Standardised DateTime values allows for users to read values easier Correct isDone value ensure user knows when they have marked the task as done Let's ensure that tasks are displayed and stored correctly

Increase code readability

Add HelpCommand feature

Fix DateTime parsing to provide correct time

damithc and others added 14 commits July 11, 2024 16:52

Add Gradle support

68c58c1

Bump gradle and lib version

03523ec

Add Carol.java and delete Duke.java

cabc6f0

Echo message

93c2191

Add messages to list

b110548

Added Task file and mark

e8fb76b

ToDos, Events, Deadlines

b59fd19

Error Handling

9b8ec7d

Delete Tasks

024bc8c

Added SaveTasks and LoadTasks functionality

b75e5eb

Merge branch 'branch-Level-7'

16861f9

Add Date and Time Functionality

18c606b

Merge branch 'branch-Level-8'

c9bacb3

KimHan01 reviewed Feb 6, 2025

View reviewed changes

mistyk786 added 3 commits February 9, 2025 12:28

Used more OOP

7b003dc

Merge branch 'branch-MoreOOP'

a8a1734

Merge branch 'add-gradle-support'

39506cb

jensenhuangyankai reviewed Feb 9, 2025

View reviewed changes

mistyk786 added 7 commits February 9, 2025 19:24

Added gradle automation and testing

29047cb

Changed class names to match coding standard

d11b3cc

Added JavaDoc comments

2eb3123

Added Find command

a683988

Merge branch 'A-CodingStandard'

13303aa

Merge branch 'A-JavaDoc'

6e30ec4

Merge branch 'Level-9'

e0f29b5

nikingoda reviewed Feb 9, 2025

View reviewed changes

mistyk786 added 3 commits February 18, 2025 17:43

Added dependencies

2e1164f

Added GUI

c4b762b

Merge branch 'Level-10'

aab8546

mistyk786 and others added 13 commits February 19, 2025 23:53

Remove duplicate code fragments

af95083

Increase code readability

Merge branch 'branch-A-CodeQuality'

7e40ffa

Add HelpCommand feature

2eefd3a

Fix DateTime parsing to provide correct time

e7ba454

Merge pull request #3 from mistyk786/branch-helpCommand

6e12de1

Add HelpCommand feature

Merge branch 'master' into B-Reminders

2a8abb6

Merge pull request #2 from mistyk786/B-Reminders

b33a5f7

Fix DateTime parsing to provide correct time

Push tag

6d449ba

Create JAR file

58e411e

README update

123faa5

Fix Ui image

753ccc8

Add README to docs

c51a5ce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mustafa Abbas iP #467

Mustafa Abbas iP #467

mistyk786 commented Feb 6, 2025 •

edited

Loading

KimHan01 left a comment

KimHan01 Feb 6, 2025

KimHan01 Feb 6, 2025

KimHan01 Feb 6, 2025

KimHan01 Feb 6, 2025

jensenhuangyankai Feb 9, 2025

jensenhuangyankai Feb 9, 2025

jensenhuangyankai Feb 9, 2025

jensenhuangyankai Feb 9, 2025

nikingoda Feb 9, 2025

nikingoda Feb 9, 2025

nikingoda Feb 9, 2025

nikingoda Feb 9, 2025

nikingoda Feb 9, 2025

nikingoda Feb 9, 2025

Mustafa Abbas iP #467

Are you sure you want to change the base?

Mustafa Abbas iP #467

Conversation

mistyk786 commented Feb 6, 2025 • edited Loading

🚀 Cortana – Your AI Task Manager

✨ Getting Started

📌 Features

Task Capabilities

🖥️ Java Programmers, Here's the Entry Point

KimHan01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mistyk786 commented Feb 6, 2025 •

edited

Loading