【Heng Jee Kuan] iP #457

hengjeekuan · 2025-02-04T18:19:46Z

JeeniusPro

"Your mind is for having ideas, not holding them." - David Allen (source)

JeeniusPro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is.

download it from here
double click it
add your tasks
let it manage for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.

nictjh

Good work man, learnt alot from ya

nictjh · 2025-02-06T20:37:16Z

src/main/java/jeenius/command/Parser.java

+            ui.printTaskList(tasks.getTasks());
+        } else if (input.startsWith("todo")) {
+            String[] parts = input.split(" ", 2);
+            if (parts.length < 2) throw new JeeniusException("bro how do you todo nothing??? ADD A DESCRIPTION FOR YOUR TODO");


The conditional should be put on a separate line, could help in future debugging if necessary :>!
Other than that LGTM!!

nictjh · 2025-02-06T20:39:39Z

src/main/java/jeenius/storage/Storage.java

+                boolean isDone = parts[1].trim().equals("1");
+                String description = parts[2].trim();
+
+                switch (taskType) {


The case clauses shouldn't have any indentation as per coding standards. Can try to configure IDE to standardise the style

nictjh · 2025-02-06T20:43:14Z

src/main/java/jeenius/task/Task.java

+        return this.description;
+    }
+
+    public Boolean getDone() {


This getter function can follow the "use a prefix such as is, has, was, etc. for boolean variables and methods". (Small things man give chance need fill quota)

nictjh · 2025-02-06T20:47:45Z

src/main/java/jeenius/Jeenius.java

+            loadedTasks = new TaskList(storage.load());
+        } catch (JeeniusException e) {
+            ui.printError(e.getMessage());
+            loadedTasks = new TaskList(new ArrayList<>());


The Generic here could be filled with the super class (Task) for clarity, readability, and type safety. Prevent any inference made by Java.

nictjh · 2025-02-06T20:49:09Z

src/main/java/jeenius/list/TaskList.java

+import java.util.ArrayList;
+import java.util.List;
+
+public class TaskList {


nictjh · 2025-02-06T20:50:22Z

src/main/java/jeenius/task/Deadline.java

+import java.time.LocalDateTime;
+import java.time.format.DateTimeFormatter;
+
+public class Deadline extends Task {


nictjh · 2025-02-06T20:50:46Z

src/main/java/jeenius/task/Event.java

+import java.time.LocalDateTime;
+import java.time.format.DateTimeFormatter;
+
+public class Event extends Task {


nictjh · 2025-02-06T20:53:20Z

src/main/java/jeenius/ui/Ui.java

+
+import java.util.List;
+
+public class Ui {


Good job man, there's really nothing to nitpick at all

pastchum

Very good code, apart from few minor nits this code was very well done!

pastchum · 2025-02-07T17:52:10Z

src/main/java/jeenius/Jeenius.java

+                ui.printError(e.getMessage());
+            }
+        }
+    }


Good naming conventions, good code

pastchum · 2025-02-07T17:53:31Z

src/main/java/jeenius/command/Parser.java

+            ui.printTaskList(tasks.getTasks());
+        } else if (input.startsWith("todo")) {
+            String[] parts = input.split(" ", 2);
+            if (parts.length < 2) throw new JeeniusException("bro how do you todo nothing??? ADD A DESCRIPTION FOR YOUR TODO");


Line is too long, can be difficult to read. consider splitting into 2 lines.

pastchum · 2025-02-07T17:55:57Z

src/main/java/jeenius/command/Parser.java

+            } catch (Exception e) {
+                throw new JeeniusException("Failed to mark/unmark. Use: mark/unmark [task number]");
+            }
+        } else {


I like the way you format the code in each "if" case. Very readable and neat, except for the few lines that seem to be very long and can be split into 2.

pastchum · 2025-02-07T17:56:56Z

src/main/java/jeenius/list/TaskList.java

+    public Task getTask(int index) {
+        return tasks.get(index);
+    }
+


Should name method getSize to follow naming standard for methods. Apart from that LGTM

pastchum · 2025-02-07T18:00:09Z

src/main/java/jeenius/ui/Ui.java

+
+public class Ui {
+
+    public void printWelcomeMessage() {


Good use of already defined functions to neaten and reduce repeated code. LGTM

Assertions have been added to Tasklist.java to document important assumptions and prevent potential runtime errors. These assertions serve to verify that critical conditions hold throughout the program execution reducing chances of unexpected behaviour. Let's: - Add an assertion in the constructor to ensure the task list is never null after initialization - Add an assertion in 'findTasks()' to prevent a 'NullPointerException' when processing a search keyword - Add an assertion in 'deleteTask()' and 'getSize()' to validate that the provided index is within bounds before performing operations - Add an assertion in 'addTask()' to prevent null tasks from being added

…straints Assertions have been added to Parser.java to ensure that critical conditions are met before executing commands. These assertions help catch logical errors early during development and debugging, improving the robustness of the parser. Let's: - Add assertions to validate that `input`, `tasks`, `ui`, and `storage` are not null before processing commands. - Ensure that `deleteTask()`, `mark/unmark`, and `getSize()` only operate on valid task indices, preventing out-of-bounds errors. - Add assertions in `findTasks()` and task creation commands (`todo`, `deadline`, `event`) to verify that input strings are not null or empty. - Enforce correct splitting of parameters in `deadline` and `event` tasks to prevent index errors.

…put handling Assertions have been added to Jeenius.java to ensure that essential components are properly initialized and critical input validations are enforced. These assertions help catch logical errors early, preventing unintended behavior. Let's - Add assertions to validate that `filePath` is not null or empty before initializing storage. - Ensure that `ui`, `storage`, `parser`, and `tasks` are not null after initialization. - Add assertions in `run()` to verify that the `ui` and `parser` are ready before execution. - Includ an assertion in `getResponse()` to ensure the input string is never null. - Verifiy that user input in `run()` is not null before processing.

Branch-A-Assertions

Improve code quality

damithc and others added 27 commits July 11, 2024 16:52

Add Gradle support

68c58c1

Bump gradle and lib version

03523ec

Edited Duke.java

63080df

Changed all occurrences of Duke to Jeenius

9157676

Added Echo function

0bb16f7

Added ability to store text and list them

90f184a

Added ability to mark tasks as done

e2e37e2

Created methods instead to prevent repetitive code

05bdee7

Added Deadline and Event class

b29d47a

Added Todos, Events and Deadlines class

e04603a

Added TextUiTesting

544ec0d

Added all error handling

52a0ed6

Added delete method

ef3d28c

Added ability to create data folder if doesn't exist

1b0a86d

Added method to save tasks

a765583

Add save tasks method into all methods that edit list

dc5e316

Add save function

3d9b7fa

Merge branch 'branch-Level-7'

1bb2969

Fix bugs

8dbd8c6

Update event and deadline task

72228e1

Add dates and time

aae7edc

Add Jeenius.txt

8387027

Merge branch 'branch-Level-8'

ed66c9a

Extract out code into more classes

2cf6cb5

Move java files into respective packages

eb6720a

Merge remote-tracking branch 'origin/add-gradle-support'

d09a002

nictjh reviewed Feb 6, 2025

View reviewed changes

pastchum reviewed Feb 7, 2025

View reviewed changes

Add JUnit

8c918dc

hengjeekuan and others added 30 commits February 12, 2025 00:56

Add Javadoc for TaskList.java

f7e1829

Add JavaDoc to Storage.java

f9d5d45

Add JavaDoc comments to Jeenius.java, JeeniusException.java and Ui.java

a074fa0

Add A-CodingStandard

31dec8f

Merge branch 'branch-A-JavaDoc'

c8b38d2

Merge branch 'branch-A-CodingStandard'

2fc264d

Merge branch 'branch-Level-9'

9ae24ed

Fix checkstyles error

f46c2fa

Add dependencies in build.gradle

53e2102

Add up to Part 2 for JavaFX

55deee5

Add Iteration 1 of Part 3

c669f64

Add ScrollPane

d230bc7

Add Iteration 2 of Part 3

c4bcf96

Add Iteration 3 of Part 3

5816343

Add FXML

80d9aa3

Add GUI

3f66172

Merge branch 'branch-Level-10'

ff23b46

Merge pull request #2 from hengjeekuan/branch-A-Assertions

6474099

Branch-A-Assertions

Improve code quality

d58a1a6

Merge pull request #3 from hengjeekuan/branch-A-CodeQuality

a4cd0bc

Improve code quality

Edit code so that GUI that opens up is running Jeenius.java

0ca594f

Merge branch 'GUI-fix'

d07156b

Add C-Sort

7a14e99

Merge branch 'branch-C-Sort'

71c4986

Improve GUI

8803d89

Set up product website

8c05d88

Change README

e2ff5a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Heng Jee Kuan] iP #457

【Heng Jee Kuan] iP #457

hengjeekuan commented Feb 4, 2025 •

edited

Loading

nictjh left a comment

nictjh Feb 6, 2025

nictjh Feb 6, 2025

nictjh Feb 6, 2025

nictjh Feb 6, 2025

nictjh Feb 6, 2025

nictjh Feb 6, 2025

nictjh Feb 6, 2025

nictjh Feb 6, 2025

pastchum left a comment

pastchum Feb 7, 2025

pastchum Feb 7, 2025

pastchum Feb 7, 2025

pastchum Feb 7, 2025

pastchum Feb 7, 2025

【Heng Jee Kuan] iP #457

Are you sure you want to change the base?

【Heng Jee Kuan] iP #457

Conversation

hengjeekuan commented Feb 4, 2025 • edited Loading

JeeniusPro

nictjh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pastchum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hengjeekuan commented Feb 4, 2025 •

edited

Loading