[Xzh119] iP #450

Xzh119 · 2025-02-03T16:58:04Z

Samantha

“Your mind is for having ideas, not holding them.” – David Allen (source)

Samantha, named after the emotional AI in the movie HER, frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.

blobfish465

Overall I found your code easy to read for the most part, except for some areas where there were minor coding standard errors such as missing spacing and lines. You might want to consider splitting some single lines into several lines so it is easier to read.

blobfish465 · 2025-02-03T17:32:24Z

src/main/java/Samantha.java

+            } else {
+                if (taskSum > 99) {
+                    System.out.println("    List is full.");
+                }else {


Should there be a space between { and else?

blobfish465 · 2025-02-03T17:34:55Z

src/main/java/Task.java

+        this.isDone = false;
+    }
+
+    public String getStatusIcon() {


Good use of a camelCase for method naming.

blobfish465 · 2025-02-03T17:35:30Z

src/main/java/Task.java

@@ -0,0 +1,26 @@
+public class Task {
+    protected String description;
+    protected boolean isDone;


Good use of a boolean naming convention.

blobfish465 · 2025-02-03T17:38:12Z

src/main/java/SamanthaException.java

+public class SamanthaException extends Exception {
+    public SamanthaException(String message) {
+        super(message);
+    }
+}


Should there be more specific exceptions e.g. NumberFormatException, IndexOutOfBoundsException ?

blobfish465 · 2025-02-03T17:39:12Z

src/main/java/Samantha.java

@@ -0,0 +1,140 @@
+import java.util.Scanner;
+import java.util.ArrayList;


You might want to leave a line below this statement before defining your public class

# Conflicts: # src/main/java/Task.java

* 'master' of https://github.com/Xzh119/ip: Test b Test a

Taoseeker

The code LGTM, despite some possible improvement in following coding standard. Additaionally, I like how the naming explain the usage of a field/method clearly.

Taoseeker · 2025-02-06T14:10:01Z

src/main/java/Task.java

+        String type = parts[0];
+
+        switch (type) {
+            case "T":


Maybe the indentation for case clauses could be removed according to coding standard?

Taoseeker · 2025-02-06T14:10:52Z

src/main/java/Task.java

@@ -0,0 +1,48 @@
+public class Task {


Should Task be an abstract class instead?

Taoseeker · 2025-02-06T14:12:23Z

src/main/java/Deadline.java

+        String[] parts = line.split(" \\| ");
+        boolean isDone = parts[1].equals("1");
+        Deadline task = new Deadline(parts[2], parts[3]);
+        if (isDone) task.markAsDone();


Maybe if should be followed by a block?

The `parseCommand` method does not have assertions to verify the validity of inputs. This may lead to unexpected runtime errors. Add assertions to ensure inputs meet expected conditions. Assertions check for null command and properly formatted commands. This helps catch potential bugs early and improves code robustness by preventing invalid operations before they can cause failures.

Merge Branch-a-assertions

Improve Code Quality

Revert "Improve Code Quality"

Merge branch 'master' into branch-A-CodeQuality

It needs to be change as it affects the purpose of listing. It is fixed by preventing the "\n" at the end. It is done this way because it is reasonable and easy.

damithc and others added 11 commits July 11, 2024 16:52

Add Gradle support

68c58c1

Bump gradle and lib version

03523ec

add Level 0

61a6f48

Add Echo

fe650e9

Add list and add ability

211a6a3

Add a Task class and Mark as Done feature

3eff652

Add Todo, Event and Deadline class

88572fb

Add Automated Text UI Testing

5645300

Add exception to handle errors

5933032

Add Delete feature

e75f75a

blobfish465 reviewed Feb 3, 2025

View reviewed changes

Xzh119 added 9 commits February 6, 2025 03:05

Add the ability to save the tasks in the hard disk automatically

f790b26

Try merge test

76abfed

Merge branch 'master' into branch-Level-7

97b0f7e

# Conflicts: # src/main/java/Task.java

Fix merge problem

4fcc72d

Add dates and times

2b76a89

Test a

8c237df

Test b

7d974bc

Test c

ab9c0a8

Merge branch 'master' of https://github.com/Xzh119/ip

2b6ef87

* 'master' of https://github.com/Xzh119/ip: Test b Test a

Taoseeker reviewed Feb 6, 2025

View reviewed changes

许喆昊 added 8 commits February 7, 2025 02:06

Make the code more OOP

cc00b02

Divide classes into packages

d6bb590

Merge branch test

caeb8bb

Merge test 2

2c302ba

Merge test 3

072ecca

Merge test 4

06843ed

Merge branch 'branch-Test-C'

cbec99d

Add comment for Parser class

1cc4f07

许喆昊 and others added 30 commits February 14, 2025 12:16

Merge branch 'add-gradle-support'

1e4f6c8

Set up gradle

120de94

Add test for Ui and Parser

1691d60

Package a jar file and add a new release

977322d

Add JavaDoc comments

ef154c3

Tweak the code to comply with a coding standard

a9e2083

Add the ability to find tasks

ef0e7b9

Merge branch 'branch-A-JavaDoc'

cfc7a4b

Merge branch 'branch-A-CodingStandard'

0739ecc

Merge branches and fix conflicts

75cf833

Add a GUI to the chatbot

f95b4ec

Merge branch 'branch-Level-10'

1067151

Fix potential conflicts

2574e02

Change jar name

b6e44f0

Add assertions to DialogBox and Main

39340d5

Improve Code Quality

3abb3fd

Merge pull request #2 from Xzh119/branch-A-Assertions

c970453

Merge Branch-a-assertions

Merge branch 'master' into branch-A-CodeQuality

fa88352

Merge pull request #3 from Xzh119/branch-A-CodeQuality

bcc3ecc

Improve Code Quality

Revert "Improve Code Quality"

b4de765

Merge pull request #4 from Xzh119/revert-3-branch-A-CodeQuality

49e72bd

Revert "Improve Code Quality"

Merge pull request #5 from Xzh119/branch-A-CodeQuality

36e723c

Merge branch 'master' into branch-A-CodeQuality

Friendlier syntax for commands

cf5bc8d

Merge branch 'branch-C-FriendlierSyntax'

285637e

Fix the bug of a redundant line generated by list command

93dedfe

It needs to be change as it affects the purpose of listing. It is fixed by preventing the "\n" at the end. It is done this way because it is reasonable and easy.

Add Ui picture

d248e54

Add a User Guide

cc6b09d

Add comments for Task

4982e51

Add a new exception

13a7b0a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Xzh119] iP #450

[Xzh119] iP #450

Xzh119 commented Feb 3, 2025 •

edited

Loading

blobfish465 left a comment

blobfish465 Feb 3, 2025

blobfish465 Feb 3, 2025

blobfish465 Feb 3, 2025

blobfish465 Feb 3, 2025

blobfish465 Feb 3, 2025

Taoseeker left a comment

Taoseeker Feb 6, 2025

Taoseeker Feb 6, 2025

Taoseeker Feb 6, 2025

		@@ -0,0 +1,140 @@
		import java.util.Scanner;
		import java.util.ArrayList;

[Xzh119] iP #450

Are you sure you want to change the base?

[Xzh119] iP #450

Conversation

Xzh119 commented Feb 3, 2025 • edited Loading

Samantha

blobfish465 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Taoseeker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xzh119 commented Feb 3, 2025 •

edited

Loading