Wang Haitao iP #449
Open
Wang Haitao iP #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
1. Better modularisation of the code 2. added delete function 3. fixed output format problem
DESU-CLUB
suggested changes
Feb 6, 2025
src/out/production/ip/Deadline.class
Outdated
There was a problem hiding this comment.
You might want to git ignore the .class
src/main/java/Task.java
Outdated
There was a problem hiding this comment.
Great naming conventions here for the formats!
src/main/java/Duke.java
Outdated
| } else { | ||
| try { | ||
| switch(parts[0]) { | ||
| case "deadline": |
There was a problem hiding this comment.
Based on the coding standards, cases have no indentations (same indent as switch)
src/main/java/TaskList.java
Outdated
| @@ -0,0 +1,68 @@ | |||
| import utils.Utils; | |||
|
|
|||
| import java.util.ArrayList; | |||
There was a problem hiding this comment.
Might be better to put ArrayList before custom imports like utils, as that caused me to violate the checkstyle
However the coding standards dont enforce this to that degree so this is really up to your personal preference
src/main/java/Duke.java
Outdated
| @@ -3,7 +3,7 @@ | |||
| import java.util.Optional; | |||
There was a problem hiding this comment.
I really like how you're using typing in order to annotate your classes and allow for empties!
src/main/java/TaskList.java
Outdated
Comment on lines
15
to
45
| public void add_item(Task item) { | ||
| this.list.add(item); | ||
| System.out.println("Got it. I've added this task:"); | ||
| printTask(item); | ||
| Utils.output("Now you have " + this.list.size() + " tasks in the list."); | ||
| saveToFile(); | ||
| } | ||
|
|
||
| public void delete_item_by_index(int index) throws DukeException { | ||
| if (index < 1 || index > list.size()) { | ||
| throw new DukeException("Invalid task number! Please provide a number between 1 and " + list.size()); | ||
| } | ||
| Task removedTask = list.remove(index - 1); | ||
| System.out.println("Noted. I've removed this task:"); | ||
| printTask(removedTask); | ||
| Utils.output("Now you have " + this.list.size() + " tasks in the list."); | ||
| saveToFile(); | ||
|
|
||
| } | ||
|
|
||
| public void mark_done_by_index(int idx) { | ||
| if (idx > this.list.size()){ | ||
| Utils.output("Task number does not exist!"); | ||
| }else{ | ||
| System.out.println("Nice! I've marked this task as done:"); | ||
| Task item = this.list.get(idx - 1); | ||
| item.markDone(); | ||
| printTask(item); | ||
| saveToFile(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please follow the naming convention for class methods.
Suggested:
addItem(args)
deleteItem(args)
markDone(args)
* branch-A-CodingStandard: Fix coding standard violation # Conflicts: # src/main/java/duke/Parser.java
Add comprehensive assertions throughout Parser and Storage classes to document and validate important code assumptions and invariants. These assertions serve as both documentation and runtime checks during development. Parser changes: - Add input validation assertions for all parameters - Validate command string formatting and processing - Add assertions for task-specific format requirements - Ensure index operations remain within valid bounds - Document state invariants after string operations Storage changes: - Add constructor validation for file path parameters - Validate data structure integrity for task lists - Add file operation invariants for read/write operations - Ensure task conversion maintains data integrity - Add format validation for task string parsing
Add comprehensive Javadoc comments to improve code documentation: - Add class-level documentation for Parser - Document all public and private methods - Specify input formats and validation rules - Document error conditions and exceptions No functional changes, documentation only.
Initial commit
Branch a assertions
Branch a code quality
* branch-Level-10: Add better gui and finish up level 10 design Initial commit
Parser accepts deadline command with empty date value after /by keyword. This causes unexpected exceptions when processing the command. Add validation check to ensure deadline date is provided. This ensures proper error message instead of runtime exceptions. Similar validation needed for event parameters in future commits.
* 'master' of github.com:HAITAO2003/ip: Update README.md Update README.md Update README.md Update README.md
DialogBox class lacks proper documentation for its functionality and components. This makes it difficult for new developers to understand the code purpose and usage. Add comprehensive JavaDoc comments to class, methods, and fields. Documentation describes the purpose of each component without changing any existing code. Improved documentation aids in code maintenance and facilitates better understanding of the GUI dialog system implementation.
Event class date-time fields are mutable and could potentially be modified after creation. This violates the principle of immutability and could lead to inconsistent state. Make startDateTime and endDateTime fields final to ensure immutability. This guarantees that event time data remains consistent throughout the object lifecycle. The change is minimal but improves code robustness and maintainability.
MainWindow class lacks proper documentation of its UI components and functionality. This makes it difficult for new developers to understand the controller's purpose and behavior. Add comprehensive JavaDoc comments to class, fields, and methods. Documentation clarifies the role of each UI component and method without changing any functionality. Improved documentation enhances code maintainability and provides better understanding of the main window controller's responsibilities in the Duke application.
Field-level JavaDoc comments are redundant and state the obvious. These verbose comments add noise without providing meaningful information. Remove excessive field-level JavaDoc comments while preserving method documentation. This maintains meaningful documentation while improving code readability. Class and method JavaDoc remain intact to preserve important contextual information.
Method uses type casting after instanceof checks to access subclass methods. This approach is verbose and requires redundant type casting. Implement pattern matching with instanceof to simplify variable handling. The refactoring reduces code verbosity while maintaining the same functionality.
Storage class uses verbose lambda expressions, manual type casting, and has redundant assertions. These patterns make the code unnecessarily verbose and harder to maintain. Replace lambdas with method references, implement pattern matching, and remove redundant assertions. This leverages Java's modern features for more concise code while maintaining necessary validations. Code functionality remains identical while reducing verbosity and potential for errors.
Project lacks visual representation and documentation in standard location. This makes it difficult for users to understand the application's appearance and usage. Add GUI screenshot and README file to the docs directory. This follows standard practice for GitHub documentation and improves project presentation. Documentation in the proper location improves discoverability for new users and contributors.
fix link to release page
Application's mascot name "Duke" is generic and lacks personality. A more distinctive name would enhance the user experience and brand identity. Change mascot name from "Duke" to "Dumpling" throughout the application. This includes updating UI text, documentation, and related references. The new name adds uniqueness and character to the application while maintaining the same functionality and user interaction patterns.
- Add Launcher class to properly initialize JavaFX application - Update build.gradle to include platform-specific JavaFX dependencies - Configure shadowJar plugin to package all dependencies in a single executable JAR - Fix cross-platform compatibility issues for Windows, Mac, and Linux Resolves issue with "JavaFX runtime components are missing" error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke Task Manager: Now with JavaFX GUI! 🎨
Major Updates in this PR
Implementation Details
Created new JavaFX components:
Modified existing components:
Dukeclass to support GUIUiclass for visual outputCode Example
Project Status
Technical Details
The project now uses
JavaFXfor the GUI, with FXML for layout management. The original functionality is maintained through thecommand line interfacenew graphical interface.For more information about JavaFX, visit OpenJFX documentation.