-
-
Notifications
You must be signed in to change notification settings - Fork 197
Analysis of air pollution levels before and after lockdown in Delhi, India #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…efore and after lockdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mukulikaa! A few initial comments:
- Make sure you add your tutorial to the README and the
applications.md
file, so it's shown on the ToC for the rendered site. - I like that this is a simple application, but that means it might be better suited for beginners. In that case, we need to break down the code and explanations about what we're doing a little more. In particular, it might be nice to highlight the NumPy methods and functions being used in the computations.
- This is a style issue, and you may very well disagree, but since we are using notebooks, I'd prefer if the comments were not made on the code, but as markdown text, whenever possible.
- It would be nice to add a few links to references for the Wilcoxon test and the t-test, at least.
Thanks, @melissawm! I'll include these in my next version. |
The rendered tutorial is here. I have tried to include some explanations or links wherever suitable to make it more or else self-contained. Let me know if I should add more explanations or any other improvements! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mukulikaa ! I have left a few tiny comments but overall this is really nice. I'm happy with it! Thanks 🎉
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Thanks, @melissawm! |
I'll leave it up for a few days in case @rossbar wants to take a look - thanks @Mukulikaa ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @Mukulikaa , very nice work!
I've left a few comments but there's no blockers - take them or leave them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work (as usual) @Mukulikaa, thanks!
Thanks, @rossbar and @melissawm, for all your help! |
Congrats and thanks for all the hard work, @Mukulikaa ! |
This is the barebones of the air quality analysis tutorial. I have added some explanations so that people will have at least a high-level idea of the tutorial. I am going to add explanations and some more descriptive statistics soon.
Closes gh-110.
cc: @melissawm @rossbar