Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Serving GA for 1.5 #2422

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Serving GA for 1.5 #2422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8c9c5
feat: controller changes for adding user-defined serving store (#2421)
vigith Feb 23, 2025
af96758
chore: add inbuilt serving store (#2423)
kohlisid Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 41 additions & 9 deletions api/json-schema/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19582,6 +19582,10 @@
"description": "ServiceAccountName applied to the pod",
"type": "string"
},
"servingStoreName": {
"description": "Names of the serving store used in this vertex.",
"type": "string"
},
"sideInputs": {
"description": "Names of the side inputs used in this vertex.",
"items": {
Expand Down Expand Up @@ -19687,6 +19691,23 @@
},
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.BuiltInServingStore": {
"description": "BuiltInServingStore to track and store data and metadata for tracking and serving.",
"properties": {
"ttl": {
"$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Duration",
"description": "TTL for the data in the store and tracker"
},
"url": {
"description": "URL of the persistent store to write the callbacks",
"type": "string"
}
},
"required": [
"url"
],
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.CombinedEdge": {
"description": "CombinedEdge is a combination of Edge and some other properties such as vertex type, partitions, limits. It's used to decorate the fromEdges and toEdges of the generated Vertex objects, so that in the vertex pod, it knows the properties of the connected vertices, for example, how many partitioned buffers I should write to, what is the write buffer length, etc.",
"properties": {
Expand Down Expand Up @@ -21538,6 +21559,10 @@
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.PipelineLimits",
"description": "Limits define the limitations such as buffer read batch size for all the vertices of a pipeline, they could be overridden by each vertex's settings"
},
"servingStore": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.ServingStore",
"description": "ServingStore defines the Serving Store for this pipeline."
},
"sideInputs": {
"description": "SideInputs defines the Side Inputs of a pipeline.",
"items": {
Expand Down Expand Up @@ -21934,7 +21959,7 @@
"type": "boolean"
},
"store": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.ServingStore",
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.BuiltInServingStore",
"description": "Persistent store for the callbacks for serving and tracking"
}
},
Expand All @@ -21945,19 +21970,18 @@
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.ServingStore": {
"description": "ServingStore to track and store data and metadata for tracking and serving.",
"description": "ServingStore defines information of a Serving Store used in a pipeline",
"properties": {
"ttl": {
"$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Duration",
"description": "TTL for the data in the store and tracker"
"container": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Container"
},
"url": {
"description": "URL of the persistent store to write the callbacks",
"name": {
"type": "string"
}
},
"required": [
"url"
"name",
"container"
],
"type": "object"
},
Expand Down Expand Up @@ -22555,6 +22579,10 @@
"description": "ServiceAccountName applied to the pod",
"type": "string"
},
"servingStoreName": {
"description": "Names of the serving store used in this vertex.",
"type": "string"
},
"sideInputs": {
"description": "Names of the side inputs used in this vertex.",
"items": {
Expand Down Expand Up @@ -22984,6 +23012,9 @@
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
"servingStore": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.ServingStore"
},
"volumeMounts": {
"items": {
"$ref": "#/definitions/io.k8s.api.core.v1.VolumeMount"
Expand All @@ -22998,7 +23029,8 @@
"image",
"volumeMounts",
"resources",
"executeRustBinary"
"executeRustBinary",
"servingStore"
],
"type": "object"
}
Expand Down
50 changes: 41 additions & 9 deletions api/openapi-spec/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19590,6 +19590,10 @@
"description": "ServiceAccountName applied to the pod",
"type": "string"
},
"servingStoreName": {
"description": "Names of the serving store used in this vertex.",
"type": "string"
},
"sideInputs": {
"description": "Names of the side inputs used in this vertex.",
"type": "array",
Expand Down Expand Up @@ -19691,6 +19695,23 @@
}
}
},
"io.numaproj.numaflow.v1alpha1.BuiltInServingStore": {
"description": "BuiltInServingStore to track and store data and metadata for tracking and serving.",
"type": "object",
"required": [
"url"
],
"properties": {
"ttl": {
"description": "TTL for the data in the store and tracker",
"$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Duration"
},
"url": {
"description": "URL of the persistent store to write the callbacks",
"type": "string"
}
}
},
"io.numaproj.numaflow.v1alpha1.CombinedEdge": {
"description": "CombinedEdge is a combination of Edge and some other properties such as vertex type, partitions, limits. It's used to decorate the fromEdges and toEdges of the generated Vertex objects, so that in the vertex pod, it knows the properties of the connected vertices, for example, how many partitioned buffers I should write to, what is the write buffer length, etc.",
"type": "object",
Expand Down Expand Up @@ -21525,6 +21546,10 @@
"description": "Limits define the limitations such as buffer read batch size for all the vertices of a pipeline, they could be overridden by each vertex's settings",
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.PipelineLimits"
},
"servingStore": {
"description": "ServingStore defines the Serving Store for this pipeline.",
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.ServingStore"
},
"sideInputs": {
"description": "SideInputs defines the Side Inputs of a pipeline.",
"type": "array",
Expand Down Expand Up @@ -21926,23 +21951,22 @@
},
"store": {
"description": "Persistent store for the callbacks for serving and tracking",
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.ServingStore"
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.BuiltInServingStore"
}
}
},
"io.numaproj.numaflow.v1alpha1.ServingStore": {
"description": "ServingStore to track and store data and metadata for tracking and serving.",
"description": "ServingStore defines information of a Serving Store used in a pipeline",
"type": "object",
"required": [
"url"
"name",
"container"
],
"properties": {
"ttl": {
"description": "TTL for the data in the store and tracker",
"$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Duration"
"container": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Container"
},
"url": {
"description": "URL of the persistent store to write the callbacks",
"name": {
"type": "string"
}
}
Expand Down Expand Up @@ -22537,6 +22561,10 @@
"description": "ServiceAccountName applied to the pod",
"type": "string"
},
"servingStoreName": {
"description": "Names of the serving store used in this vertex.",
"type": "string"
},
"sideInputs": {
"description": "Names of the side inputs used in this vertex.",
"type": "array",
Expand Down Expand Up @@ -22947,7 +22975,8 @@
"image",
"volumeMounts",
"resources",
"executeRustBinary"
"executeRustBinary",
"servingStore"
],
"properties": {
"env": {
Expand All @@ -22971,6 +23000,9 @@
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
"servingStore": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.ServingStore"
},
"volumeMounts": {
"type": "array",
"items": {
Expand Down
Loading
Loading