Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out deamon pod and unnecessary containers from metrics output #2394

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

adarsh0728
Copy link
Contributor

@adarsh0728 adarsh0728 commented Feb 12, 2025

  1. Filter out daemon pod from metrics response.
  2. Filter in only pod's containers from metrics response.

@adarsh0728 adarsh0728 changed the title fix: filter out deamon pod and unncessary containers from metrics output fix: filter out deamon pod and unnecessary containers from metrics output Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.02%. Comparing base (7d2251d) to head (e934f1f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
- Coverage   71.10%   71.02%   -0.08%     
==========================================
  Files         367      367              
  Lines       53042    53042              
==========================================
- Hits        37715    37674      -41     
- Misses      14247    14293      +46     
+ Partials     1080     1075       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adarsh0728
Copy link
Contributor Author

Screenshot 2025-02-12 at 12 21 47 PM Screenshot 2025-02-12 at 12 22 35 PM Screenshot 2025-02-12 at 12 22 56 PM Screenshot 2025-02-12 at 12 23 08 PM

@adarsh0728 adarsh0728 requested a review from veds-g February 12, 2025 07:02
@vigith
Copy link
Member

vigith commented Feb 12, 2025

@adarsh0728 what is the condition to filter out pods and containers? keep in mind that in future we will support builtins like kafka, sqs, etc., we cannot filter those out.

@adarsh0728
Copy link
Contributor Author

@adarsh0728 what is the condition to filter out pods and containers? keep in mind that in future we will support builtins like kafka, sqs, etc., we cannot filter those out.

For pods: we call pods API and filter out only daemon.
For containers of a pod: pod.spec.containers + pod.spec.initContainers(those with restartPolicy as Always)

we are not filtering out builtins with this

@veds-g
Copy link
Contributor

veds-g commented Feb 13, 2025

for filtering the containers, we do not have the pipeline or monovertex context is the metrics response. So in case of multiple containers with the same name, how do we ensure that we showing data for the particular container belonging to that pipeline vertex or monovertex?

Signed-off-by: adarsh0728 <[email protected]>
@adarsh0728 adarsh0728 marked this pull request as ready for review February 18, 2025 07:31
Copy link
Contributor

@veds-g veds-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigith vigith merged commit b918846 into numaproj:main Feb 18, 2025
25 checks passed
veds-g added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants