chore: avoid panics because of watermark code #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
yhl25
commented
Feb 12, 2025
rust/serving/src/config.rs
Outdated
Comment on lines
180
to
183
| settings.redis.ttl_secs = match serving_spec.store.ttl { | ||
| Some(ttl) => Some(Duration::from(ttl).as_secs() as u32), | ||
| None => None, | ||
| }; |
Signed-off-by: Yashash H L <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2393 +/- ##
==========================================
- Coverage 71.06% 71.03% -0.04%
==========================================
Files 367 367
Lines 53024 53028 +4
==========================================
- Hits 37683 37666 -17
- Misses 14254 14285 +31
+ Partials 1087 1077 -10 ☔ View full report in Codecov by Sentry. |
vigith
approved these changes
Feb 12, 2025
Signed-off-by: Yashash H L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.