fix: error state & search/negate search in case of prev terminated logs #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adarsh0728
commented
Feb 11, 2025
•
adarsh0728
commented
- In case logs API returns an error mssg, add/remove timestamp wouldn't work. Show the error message as it is.
- Fixes search and negate search functionality in case of previous terminated container logs.
Signed-off-by: adarsh0728 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2391 +/- ##
==========================================
+ Coverage 71.10% 71.15% +0.05%
==========================================
Files 367 367
Lines 53042 53042
==========================================
+ Hits 37715 37742 +27
+ Misses 14247 14222 -25
+ Partials 1080 1078 -2 ☔ View full report in Codecov by Sentry. |
|
|
veds-g
reviewed
Feb 17, 2025
...artials/Graph/partials/NodeInfo/partials/Pods/partials/PodDetails/partials/PodLogs/index.tsx
Outdated
Show resolved
Hide resolved
veds-g
reviewed
Feb 17, 2025
...artials/Graph/partials/NodeInfo/partials/Pods/partials/PodDetails/partials/PodLogs/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: adarsh0728 <[email protected]>
veds-g
pushed a commit
that referenced
this pull request
Feb 19, 2025
…gs (#2391) Signed-off-by: adarsh0728 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.