feat: contextual flow for remaining metrics #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: veds-g <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2379 +/- ##
==========================================
- Coverage 69.73% 69.72% -0.01%
==========================================
Files 361 361
Lines 49993 49993
==========================================
- Hits 34861 34856 -5
- Misses 14048 14056 +8
+ Partials 1084 1081 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: veds-g <[email protected]>
Signed-off-by: veds-g <[email protected]>
adarsh0728
reviewed
Feb 7, 2025
ui/src/components/common/MetricsModalWrapper/partials/MetricsModal/index.tsx
Outdated
Show resolved
Hide resolved
...c/components/common/SlidingSidebar/partials/VertexDetails/partials/ProcessingRates/index.tsx
Outdated
Show resolved
Hide resolved
adarsh0728
reviewed
Feb 7, 2025
...deInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/common/Dropdown/index.tsx
Outdated
Show resolved
Hide resolved
BulkBeing
reviewed
Feb 7, 2025
| import { PipelineVertexMetric } from "../../../../../../../types/declarations/pipeline"; | ||
| import { AppContextProps } from "../../../../../../../types/declarations/app"; |
There was a problem hiding this comment.
There was a problem hiding this comment.
can use absolute imports going forward.
Signed-off-by: veds-g <[email protected]>
Signed-off-by: veds-g <[email protected]>
adarsh0728
reviewed
Feb 10, 2025
ui/src/components/common/SlidingSidebar/partials/VertexDetails/partials/Buffers/index.tsx
Show resolved
Hide resolved
adarsh0728
approved these changes
Feb 10, 2025
veds-g
added a commit
that referenced
this pull request
Feb 19, 2025
Signed-off-by: veds-g <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2315