Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Watermark Implementation for Async Data Movement #2376

Merged
merged 37 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
a62a3f9
fetcher
yhl25 Jan 4, 2025
a99b90f
make offset mandatory, add watermark for message
yhl25 Jan 7, 2025
a487a8d
doc
yhl25 Jan 8, 2025
76ff176
Merge branch 'main' of github.com:numaproj/numaflow into watermark
yhl25 Jan 8, 2025
435cef6
change tracker to accept offset type
yhl25 Jan 8, 2025
6d6db33
watermark implementation
yhl25 Jan 13, 2025
63b95c4
watermark
yhl25 Jan 15, 2025
1b988b6
watermark
yhl25 Jan 16, 2025
5df1367
Merge branch 'main' of github.com:numaproj/numaflow into watermark
yhl25 Jan 16, 2025
8d8a283
temp
yhl25 Jan 16, 2025
25a7026
use protobuf for heartbeat
yhl25 Jan 19, 2025
675a131
Merge branch 'main' of github.com:numaproj/numaflow into watermark
yhl25 Jan 20, 2025
6d94032
feat: watermark
yhl25 Jan 22, 2025
6703900
fix conflicts
yhl25 Jan 22, 2025
9beedc6
Merge branch 'main' of github.com:numaproj/numaflow into watermark
yhl25 Jan 22, 2025
5926503
watermark
yhl25 Jan 24, 2025
8b8e73d
some optimisations
yhl25 Jan 25, 2025
bc25363
chore: just browsing the code
vigith Jan 25, 2025
7de780d
chore: still browsing the code
vigith Jan 25, 2025
a48cab8
chore: typo
vigith Jan 25, 2025
d441b7c
minor refactor, remove shared
yhl25 Jan 25, 2025
919dd29
fetcher tests
yhl25 Jan 26, 2025
1e81c49
introduce insert offset method
yhl25 Jan 27, 2025
e9673c4
chore: typo
vigith Jan 27, 2025
24bd259
chore: typo
vigith Jan 27, 2025
a66e4ae
publisher tests
yhl25 Jan 28, 2025
4a9b8f3
minor changes
yhl25 Jan 28, 2025
422274c
fix tests
yhl25 Jan 28, 2025
10f4474
add retry for watcher, delete offset after blocking write
yhl25 Jan 29, 2025
91f50b9
remove logging for now
yhl25 Jan 30, 2025
4e97e06
Merge branch 'main' of github.com:numaproj/numaflow into watermark
yhl25 Jan 30, 2025
dc7ea59
doc: corrections
vigith Jan 30, 2025
304a1d2
doc, use std locks, refactoring
yhl25 Jan 30, 2025
13a2e5c
chore: code review 44/67
vigith Jan 30, 2025
baaed96
chore: code review 57/67
vigith Jan 31, 2025
ae9421d
chore: code review 67/67
vigith Jan 31, 2025
4548fa3
address review comments
yhl25 Jan 31, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -365,4 +365,4 @@ update-manifests-version:
cat config/extensions/webhook/kustomization.yaml | sed 's/newTag: .*/newTag: $(VERSION)/' | sed 's@value: quay.io/numaproj/numaflow:.*@value: quay.io/numaproj/numaflow:$(VERSION)@' > /tmp/tmp_kustomization.yaml
mv /tmp/tmp_kustomization.yaml config/extensions/webhook/kustomization.yaml
cat Makefile | sed 's/^VERSION?=.*/VERSION?=$(VERSION)/' | sed 's/^BASE_VERSION:=.*/BASE_VERSION:=$(VERSION)/' > /tmp/ae_makefile
mv /tmp/ae_makefile Makefile
mv /tmp/ae_makefile Makefile
2 changes: 1 addition & 1 deletion hack/generate-proto.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,5 @@ gen-protoc pkg/apis/proto/mvtxdaemon/mvtxdaemon.proto

gen-protoc pkg/apis/proto/isb/message.proto

gen-protoc pkg/apis/proto/wmb/wmb.proto
gen-protoc pkg/apis/proto/watermark/watermark.proto

265 changes: 265 additions & 0 deletions pkg/apis/proto/watermark/watermark.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ limitations under the License.
syntax = "proto3";
option go_package = "github.com/numaproj/numaflow/pkg/apis/proto/isb";

package wmb;
package watermark;

// WMB is used in the KV offset timeline bucket as the value for the given processor entity key.
message WMB {
Expand All @@ -38,4 +38,10 @@ message WMB {

// Partition to identify the partition to which the watermark belongs.
int32 partition = 4;
}

// Heartbeat is used to track the active processors
message Heartbeat {
// Heartbeat(current time in millis) published by the active processors.
int64 heartbeat = 1;
}
Loading
Loading