-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cpu memory metrics #2332
feat: cpu memory metrics #2332
Conversation
adarsh0728
commented
Jan 15, 2025
•
edited
Loading
edited
- Adds Memory and CPU pattern in metrics config at pod level
- Adds Memory and CPU pattern in metrics config at container level [filter values added for container dropdown for a particular pod]



Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
- Coverage 69.85% 69.78% -0.07%
==========================================
Files 361 361
Lines 50040 50049 +9
==========================================
- Hits 34953 34925 -28
- Misses 14013 14041 +28
- Partials 1074 1083 +9 ☔ View full report in Codecov by Sentry. |
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
.../pages/Pipeline/partials/Graph/partials/NodeInfo/partials/Pods/partials/PodDetails/index.tsx
Outdated
Show resolved
Hide resolved
config/base/numaflow-server/numaflow-server-metrics-proxy-config.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
@@ -83,7 +85,8 @@ data: | |||
required: false | |||
|
|||
- name: mono_vertex_histogram | |||
object: mono-vertex | |||
objects: | |||
- mono-vertex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to handle the configuration change together with the release internally.
@@ -1326,6 +1327,14 @@ func (h *handler) DiscoverMetrics(c *gin.Context) { | |||
// Computing dimension data for each metric | |||
var dimensionData []Dimensions | |||
for _, dimension := range metric.Dimensions { | |||
// Check if the object is "mono-vertex", skip the "vertex"(pipeline) dimension | |||
if object == "mono-vertex" && dimension.Name == "vertex" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there some logic like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I introduced Objects
field which can be a list now instead of Object
, because there was too much duplicity of patterns in config(handling pipeline and monoVertex separately).
Now, when, frontend wants to know the metrics for monoVertex, we don't want to send the ones with dimension vertex(pipeline). Hence the check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, need to rethink and refactor the approach of doing configuration as well as the frontend implementation. Approving this PR for now to unblock.
Signed-off-by: adarsh0728 <[email protected]> Co-authored-by: Vedant Gupta <[email protected]>