chore: Fallback Sink E2E test #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Closed
KeranYang
reviewed
Apr 17, 2024
| sink: | ||
| udsink: | ||
| container: | ||
| image: quay.io/numaio/numaflow-go/fb-sink-log:stable |
There was a problem hiding this comment.
nit: could you please add the source code to numaflow-go? seems you are manually building it by uncomment the simple sink. Might be better if we have a separate example so that we utilize all the benefits of CI improvements.
There was a problem hiding this comment.
vigith
approved these changes
Apr 18, 2024
yhl25
added a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: Yashash H L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.