fix: sorting metrics chart tooltip values (#2401)

Signed-off-by: veds-g <[email protected]>
numaproj · Feb 19, 2025 · d5d4408 · d5d4408
1 parent b918846
commit d5d4408
Show file tree

Hide file tree

Showing 2 changed files with 85 additions and 41 deletions.
diff --git a/ui/src/components/common/MetricsModalWrapper/index.tsx b/ui/src/components/common/MetricsModalWrapper/index.tsx
@@ -49,12 +49,25 @@ export function MetricsModalWrapper({
   });
 
   const isClickable = useMemo(() => {
-    return (
+    if (
+      discoveredMetrics &&
       !discoveredMetricsError &&
-      !discoveredMetricsLoading &&
-      !disableMetricsCharts
-    );
-  }, [discoveredMetricsError, discoveredMetricsLoading, disableMetricsCharts]);
+      !discoveredMetricsLoading
+    ) {
+      return (
+        !disableMetricsCharts &&
+        discoveredMetrics?.data?.some(
+          (metric: any) => metric?.display_name === metricDisplayName
+        )
+      );
+    }
+    return false;
+  }, [
+    discoveredMetrics,
+    discoveredMetricsError,
+    discoveredMetricsLoading,
+    disableMetricsCharts,
+  ]);
 
   return (
     <Box>

diff --git a/.../NodeInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/LineChart/index.tsx b/.../NodeInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/LineChart/index.tsx