feat: simplified sourcer server API changes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
vigith
changed the title
vigith
reviewed
Feb 27, 2024
src/source.rs
Outdated
Comment on lines
318
to
319
| pos: Mutex<usize>, | ||
| acked: Mutex<usize>, |
There was a problem hiding this comment.
do these need to be tokio::Mutex?
There was a problem hiding this comment.
pos is held across .await points in read function. So tokio::Mutex is needed. acked can use std::sync::Mutex
|
should we return early in the read fn in the example if there are un-acked messages? |
Signed-off-by: Sreekanth <[email protected]>
vigith
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.