chore: bump python version #221
Conversation
Signed-off-by: Shrivardhan Rao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 55 55
Lines 2311 2311
Branches 119 119
=======================================
Hits 2177 2177
Misses 97 97
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pyproject.toml
Outdated
| @@ -21,7 +21,7 @@ classifiers = [ | |||
| repository = "https://github.com/numaproj/numaflow-python" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.9, <3.13" | |||
| python = ">=3.9, <4.0" | |||
There was a problem hiding this comment.
Make it < 3.14.
Things might break otherwise in future
There was a problem hiding this comment.
+1 Python changes a lot between the minor versions :)
There was a problem hiding this comment.
TBH, it is very difficult to support 5 versions of Python simultaneously and have trouble free builds. I would vote for dropping support for 3.9 if we are adding 3.13.
Anyway 3.9 is going obsolete after Oct 2025.
Signed-off-by: Shrivardhan Rao <[email protected]>
| @@ -21,7 +21,7 @@ classifiers = [ | |||
| repository = "https://github.com/numaproj/numaflow-python" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.9, <3.13" | |||
| python = ">=3.9,<3.14" | |||
There was a problem hiding this comment.
Add "Programming Language :: Python :: 3.13"
in the classifiers
There was a problem hiding this comment.
You also need to add tests to make sure python 3.13 pass
https://github.com/numaproj/numaflow-python/blob/main/.github/workflows/run-tests.yml
Signed-off-by: Shrivardhan Rao <[email protected]>
|
This is tricky, let's a CI rule for that in a follow up. I do not want to block this PR because of that. |
Signed-off-by: Shrivardhan Rao <[email protected]>
update allowed python version