Skip to content

Commit

Permalink
.
Browse files Browse the repository at this point in the history
Signed-off-by: Keran Yang <[email protected]>
  • Loading branch information
KeranYang committed Nov 5, 2024
1 parent ff8b22b commit a078db4
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion examples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<dependency>
<groupId>io.numaproj.numaflow</groupId>
<artifactId>numaflow-java</artifactId>
<version>0.8.1</version>
<version>0.8.0</version>
</dependency>

<dependency>
Expand Down
3 changes: 1 addition & 2 deletions examples/simple-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,10 @@ spec:
sink:
udsink:
container:
image: quay.io/numaio/numaflow-java/simple-sink:keran-3
image: quay.io/numaio/numaflow-java/simple-sink:keran-11
imagePullPolicy: Always
edges:
- from: in
to: cat
- from: cat
to: java-sink

2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>io.numaproj.numaflow</groupId>
<artifactId>numaflow-java</artifactId>
<version>0.8.1</version>
<version>0.8.0</version>
<packaging>jar</packaging>

<name>numaflow-java</name>
Expand Down
1 change: 0 additions & 1 deletion src/main/java/io/numaproj/numaflow/sinker/Server.java
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ public void start() throws Exception {
try {
Server.this.stop();
} catch (InterruptedException e) {
// this one clears the interrupted status - I don't think it's not good.
if (Thread.interrupted()) {
System.err.println("Thread was interrupted when trying to stop the sink gRPC server.\n"

Check warning on line 89 in src/main/java/io/numaproj/numaflow/sinker/Server.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/io/numaproj/numaflow/sinker/Server.java#L89

Added line #L89 was not covered by tests
+ "Thread interrupted status cleared");
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/numaproj/numaflow/sinker/Service.java
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ public void shutDown() {
}
log.info("Sink executor was terminated.");
} catch (InterruptedException e) {
// this one clears the interrupted status - I don't think it's not good.
// this one clears the interrupted status
if (Thread.interrupted()) {
System.err.println("Thread was interrupted when trying to stop the sink service task executor.\n"

Check warning on line 223 in src/main/java/io/numaproj/numaflow/sinker/Service.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/io/numaproj/numaflow/sinker/Service.java#L223

Added line #L223 was not covered by tests
+ "Thread interrupted status cleared");
Expand Down

0 comments on commit a078db4

Please sign in to comment.