Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multi-architecture builds #142

Merged
merged 3 commits into from
Aug 20, 2024
Merged

fix: multi-architecture builds #142

merged 3 commits into from
Aug 20, 2024

Conversation

ayildirim21
Copy link
Member

fixes #140

@ayildirim21
Copy link
Member Author

ARM64 image now contains ARM64 binary:

docker pull quay.io/numaio/numaflow-go/source-simple-source:test
docker create quay.io/numaio/numaflow-go/source-simple-source:test
docker cp 47b6d52f3fb91667bc346c50a21d53006b5f84c2d8c0f13c9b81d08bdb171d89:/bin/simple-source-example .
file simple-source-example

Gives us:

simple-source-example: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=HAQPKt0Cbx8AC5Tf_M3K/siYBCYGh18kTcjLgTEJM/DEsZ9_DBxT1WHWosA9pg/JgAVEZP6x8i5MyjWinb6, with debug_info, not stripped

@KeranYang
Copy link
Member

@yhl25 @BulkBeing please review.

@KeranYang KeranYang merged commit b559600 into numaproj:main Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeranYang KeranYang KeranYang left review comments

@BulkBeing BulkBeing BulkBeing approved these changes

@yhl25 yhl25 yhl25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARM64 image of simple-source contains amd64 binary
4 participants
@ayildirim21 @KeranYang @BulkBeing @yhl25