feat: implement batch map #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
vigith
reviewed
Jun 29, 2024
vigith
reviewed
Jun 29, 2024
magelisk
reviewed
Jun 29, 2024
pkg/mapper/examples/batchmap/main.go
Outdated
| msg := d.Value() | ||
| _ = d.EventTime() // Event time is available | ||
| _ = d.Watermark() // Watermark is available | ||
| results := mapper.NewBatchResponse(d.Id()) |
There was a problem hiding this comment.
Is an empty response valid to ensure prop ACK'ing of message without necessarily assigning a response message to it?
Ex. my batch is a list of JSON, but in my handler I take combine them into a list of JSON (psedo-reduce). One of the NewBatchResponse would align with the new message, but the rest I would want to acknowledge as complete, but they wouldn't have an actual response.
There was a problem hiding this comment.
We would still need to add an empty batch response for those IDs with an empty list. We expect that the number of requests in batch and number of responses to be equal.
But for you use case if you pass on an empty response with the correct ID, those should be acked
results := mapper.NewBatchResponse(d.Id())
batchResponses = batchResponses.Append(results)
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
|
merging to a tmp branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.