chore: UDS based multiproc #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <[email protected]>
whynowy
reviewed
Apr 24, 2024
| @@ -55,7 +55,7 @@ func Test_Read_Write(t *testing.T) { | |||
| filepath := os.TempDir() + "/server-info" | |||
| defer os.Remove(filepath) | |||
| info := &ServerInfo{ | |||
| Protocol: TCP, | |||
| MultiProcServer: true, | |||
There was a problem hiding this comment.
Instead of updating the struct, can we keep the protocol, and use the metadata to populate the info? For example, in the metadata, multiProc: 4 means multProcServer with 4.
There was a problem hiding this comment.
Yes! I have updated the PRs to use the metadata to check for multiproc.
We will not need this PR change now
|
Closing this PR as it is no longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.