feat: Fallback Sink #120
Merged
feat: Fallback Sink #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
vigith
approved these changes
Apr 15, 2024
whynowy
reviewed
Apr 16, 2024
| @@ -8,6 +8,8 @@ type Response struct { | |||
| Success bool `json:"success"` | |||
| // Err represents the error message when "success" is false. | |||
| Err string `json:"err,omitempty"` | |||
| // Fallback is true if the message to be sent to the fallback sink. | |||
| Fallback bool `json:"fallback,omitempty"` | |||
There was a problem hiding this comment.
Shall we combine Fallback and Success to use a new property?
There was a problem hiding this comment.
I thought of using an enum, but enums might get tricky in some languages so went with two separate boolean values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.