Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate functionality #109

Merged
merged 1 commit into from
Mar 21, 2024
Merged

chore: remove duplicate functionality #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,3 @@ proto:
.PHONY: generate
generate:
go generate ./...

.PHONY: image-push-all
image-push-all:
Comment on lines -19 to -20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't delete the make target, put ./hack/update_examples -bp -t test command in the target?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a handy command to have in make

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. @ayildirim21 please also put a comment on the target to mention where we are pushing to(quay.io).

for dir in $(shell find ./pkg -name 'Makefile' -exec dirname {} \;); do \
$(MAKE) -C $$dir image-push TAG=$(TAG); \
done

Loading