chore: unit test merge operation as a blocking call #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds some unit tests covering cases when a merge operation is followed by non-close operations, verifying the blocking behavior of merge. Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
yhl25
approved these changes
Feb 15, 2024
ayildirim21
pushed a commit
to ayildirim21/numaflow-go
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Keran Yang <[email protected]> Signed-off-by: a3hadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds some unit tests covering cases when a merge operation is followed by non-close operations, verifying the blocking behavior of merge.
Also fixes a race condition issue when concurrently accessing the keyed window of a task.