add handshake at top level

Signed-off-by: Yashash H L <[email protected]>
numaproj · Sep 17, 2024 · ee2f308 · ee2f308
1 parent f2746d0
commit ee2f308
Show file tree

Hide file tree

Showing 4 changed files with 63 additions and 62 deletions.
diff --git a/pkg/apis/proto/source/v1/source.pb.go b/pkg/apis/proto/source/v1/source.pb.go
diff --git a/pkg/apis/proto/source/v1/source.proto b/pkg/apis/proto/source/v1/source.proto
@@ -95,13 +95,13 @@ message ReadResponse {
     Code code = 2;
     optional Error error = 3;
     optional string msg = 4;
-    optional Handshake handshake = 5;
   }
   // Required field holding the result.
   Result result = 1;
   // Status of the response. Holds the end of transmission flag and the status code.
   //
   Status status = 2;
+  optional Handshake handshake = 3;
 }
 
 /*

diff --git a/pkg/sourcer/service.go b/pkg/sourcer/service.go
@@ -65,9 +65,9 @@ func (fs *Service) ReadFn(stream sourcepb.Source_ReadFnServer) error {
 			Status: &sourcepb.ReadResponse_Status{
 				Eot:  false,
 				Code: sourcepb.ReadResponse_Status_SUCCESS,
-				Handshake: &sourcepb.Handshake{
-					Sot: true,
-				},
+			},
+			Handshake: &sourcepb.Handshake{
+				Sot: true,
 			},
 		}
 		if err := stream.Send(handshakeResponse); err != nil {

diff --git a/pkg/sourcer/service_test.go b/pkg/sourcer/service_test.go
@@ -167,9 +167,9 @@ func TestService_ReadFn(t *testing.T) {
 					Status: &sourcepb.ReadResponse_Status{
 						Eot:  false,
 						Code: sourcepb.ReadResponse_Status_SUCCESS,
-						Handshake: &sourcepb.Handshake{
-							Sot: true,
-						},
+					},
+					Handshake: &sourcepb.Handshake{
+						Sot: true,
 					},
 				},
 				{