address comments

Signed-off-by: a3hadi <[email protected]>
numaproj · Mar 11, 2024 · 90886dc · 90886dc
1 parent 43854ed
commit 90886dc
Show file tree

Hide file tree

Showing 19 changed files with 38 additions and 36 deletions.
diff --git a/.github/workflows/build-push.yaml b/.github/workflows/build-push.yaml
@@ -8,6 +8,7 @@ on:
 
 jobs:
   docker_publish:
+    name: Build, Tag, and Push Images
     runs-on: ubuntu-latest
 
     strategy:

diff --git a/development.md b/development.md
@@ -20,9 +20,10 @@ with the tag `stable`. This consistent tag name is used so that the tags in the
 updated each time a new change is made. 
 2. After the changes have been merged it is encouraged to update the dependency management files so that the version 
 displayed in the `go.mod` file reflects the commit SHA of the merged changes. This can be done by getting the
-commit SHA of the merged changes and using it with the update script: 
+commit SHA of the merged changes and using it with the update script. Alternatively, you can provide the specific version that you would like to update to, or even
+pass in `latest` to fetch the latest version from the remote repository:
 ```shell
-./update_examples -u <SDK-version>
+./update_examples -u <SDK-version | commit-sha | latest>
 ```
 After running the script, create another PR for these changes.
 

diff --git a/pkg/mapper/examples/even_odd/Makefile b/pkg/mapper/examples/even_odd/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/even-odd-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/map-even-odd:${TAG}" --platform linux/amd64,linux/arm64 --target even-odd . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/map-even-odd:${TAG}" --target even-odd .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/map-even-odd:${TAG}"; fi

diff --git a/pkg/mapper/examples/flatmap/Makefile b/pkg/mapper/examples/flatmap/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/flatmap-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/map-flatmap:${TAG}" --platform linux/amd64,linux/arm64 --target flatmap . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/map-flatmap:${TAG}" --target flatmap .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/map-flatmap:${TAG}"; fi

diff --git a/pkg/mapper/examples/forward_message/Makefile b/pkg/mapper/examples/forward_message/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/forward-message-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/map-forward-message:${TAG}" --platform linux/amd64,linux/arm64 --target forward-message . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/map-forward-message:${TAG}" --target forward-message .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/map-forward-message:${TAG}"; fi

diff --git a/pkg/mapper/examples/retry/Makefile b/pkg/mapper/examples/retry/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/retry main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/map-retry:${TAG}" --platform linux/amd64,linux/arm64 --target retry . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/map-retry:${TAG}" --target map-retry .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/map-retry:${TAG}"; fi

diff --git a/pkg/mapper/examples/tickgen/Makefile b/pkg/mapper/examples/tickgen/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/tickgen-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/map-tickgen:${TAG}" --platform linux/amd64,linux/arm64 --target tickgen . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/map-tickgen:${TAG}" --target tickgen .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/map-tickgen:${TAG}"; fi

diff --git a/pkg/mapstreamer/examples/flatmap_stream/Makefile b/pkg/mapstreamer/examples/flatmap_stream/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/flatmap-stream-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/map-flatmap-stream:${TAG}" --platform linux/amd64,linux/arm64 --target flatmap_stream . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/map-flatmap-stream:${TAG}" --target flatmap_stream .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/map-flatmap-stream:${TAG}"; fi

diff --git a/pkg/reducer/examples/counter/Makefile b/pkg/reducer/examples/counter/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/counter-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/reduce-counter:${TAG}" --platform linux/amd64,linux/arm64 --target counter . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/reduce-counter:${TAG}" --target counter .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/reduce-counter:${TAG}"; fi

diff --git a/pkg/reducer/examples/sum/Makefile b/pkg/reducer/examples/sum/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/sum-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/reduce-sum:${TAG}" --platform linux/amd64,linux/arm64 --target sum . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/reduce-sum:${TAG}" --target sum .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/reduce-sum:${TAG}"; fi

diff --git a/pkg/reducestreamer/examples/counter/Makefile b/pkg/reducestreamer/examples/counter/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/counter-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/reduce-stream-counter:${TAG}" --platform linux/amd64,linux/arm64 --target counter . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/reduce-stream-counter:${TAG}" --target counter .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/reduce-stream-counter:${TAG}"; fi

diff --git a/pkg/reducestreamer/examples/sum/Makefile b/pkg/reducestreamer/examples/sum/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/sum-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/reduce-stream-sum:${TAG}" --platform linux/amd64,linux/arm64 --target sum . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/reduce-stream-sum:${TAG}" --target sum .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/reduce-stream-sum:${TAG}"; fi

diff --git a/pkg/sessionreducer/examples/counter/Makefile b/pkg/sessionreducer/examples/counter/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/counter-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/session-counter:${TAG}" --platform linux/amd64,linux/arm64 --target counter . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/session-counter:${TAG}" --target counter .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/session-counter:${TAG}"; fi

diff --git a/pkg/sideinput/examples/simple-sideinput/Makefile b/pkg/sideinput/examples/simple-sideinput/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/sideinput-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/sideinput-example:${TAG}" --platform linux/amd64,linux/arm64 --target sideinput . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/sideinput-example:${TAG}" --target sideinput .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/sideinput-example:${TAG}"; fi

diff --git a/pkg/sideinput/examples/simple-sideinput/udf/Makefile b/pkg/sideinput/examples/simple-sideinput/udf/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/udf-sideinput-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/udf-sideinput-example:${TAG}" --platform linux/amd64,linux/arm64 --target udf-sideinput . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/udf-sideinput-example:${TAG}" --target udf-sideinput .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/udf-sideinput-example:${TAG}"; fi

diff --git a/pkg/sinker/examples/log/Makefile b/pkg/sinker/examples/log/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/log-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/sink-log:${TAG}" --platform linux/amd64,linux/arm64 --target log . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/sink-log:${TAG}" --target log .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/sink-log:${TAG}"; fi

diff --git a/pkg/sourcer/examples/simple_source/Makefile b/pkg/sourcer/examples/simple_source/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/simple-source-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/source-simple-source:${TAG}" --platform linux/amd64,linux/arm64 --target simple-source . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/source-simple-source:${TAG}" --target simple-source .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/source-simple-source:${TAG}"; fi

diff --git a/pkg/sourcetransformer/examples/assign_event_time/Makefile b/pkg/sourcetransformer/examples/assign_event_time/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/assign-event-time-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/mapt-assign-event-time:${TAG}" --platform linux/amd64,linux/arm64 --target assign-event-time . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/mapt-assign-event-time:${TAG}" --target assign-event-time .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/mapt-assign-event-time:${TAG}"; fi

diff --git a/pkg/sourcetransformer/examples/event_time_filter/Makefile b/pkg/sourcetransformer/examples/event_time_filter/Makefile
@@ -5,11 +5,11 @@ PUSH ?= false
 build:
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -o ./dist/event-time-filter-example main.go
 
-.PHONY: image
+.PHONY: image-push
 image: build
 	docker buildx build -t "quay.io/numaio/numaflow-go/mapt-event-time-filter:${TAG}" --platform linux/amd64,linux/arm64 --target event-time-filter . --push
 
-.PHONY: test_image
+.PHONY: image
 test_image: build
 	docker build -t "quay.io/numaio/numaflow-go/mapt-event-time-filter:${TAG}" --target event-time-filter .
 	@if [ "$(PUSH)" = "true" ]; then docker push "quay.io/numaio/numaflow-go/mapt-event-time-filter:${TAG}"; fi