Skip to content

Commit

Permalink
update development.md
Browse files Browse the repository at this point in the history
Signed-off-by: a3hadi <[email protected]>
  • Loading branch information
ayildirim21 committed Apr 12, 2024
1 parent 5755c00 commit 705c89a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions development.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ Note: before running the script, ensure that through the CLI, you are logged int
After confirming that your changes pass local testing:
1. Clean up testing artifacts
2. Create a PR. Once your PR has been merged, a Github Actions workflow (`Docker Publish`) will be triggered, to build, tag (with `stable`), and push
all example images. This ensures that all example images are using the most up-to-date version of the SDK, i.e. the one including your
changes
all example images. This ensures that all example images are using the most up-to-date version of the SDK, i.e. the one including your changes
3. If your SDK changes included modifications to any files in `pkg/info` or `pkg/apis/proto`, then get the commit SHA
of the merged PR from the previous step, and in the Numaflow repo run:
```shell
Expand Down

0 comments on commit 705c89a

Please sign in to comment.