Skip to content

Commit

Permalink
address comment
Browse files Browse the repository at this point in the history
Signed-off-by: a3hadi <[email protected]>
  • Loading branch information
ayildirim21 committed Apr 12, 2024
1 parent b22b4e6 commit 4819050
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
7 changes: 4 additions & 3 deletions development.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ After confirming that your changes pass local testing:
1. Clean up testing artifacts
2. Create a PR. Once your PR has been merged, a Github Actions workflow (`Docker Publish`) will be triggered, to build, tag (with `stable`), and push
all example images. This ensures that all example images are using the most up-to-date version of the SDK, i.e. the one including your changes
3. If your SDK changes included modifications to any files in `pkg/info` or `pkg/apis/proto`, then get the commit SHA
3. If your SDK changes included modifications to any files in `pkg/info` or `pkg/apis/proto`, it is necessary
to update the `go.mod` file in the Numaflow repo. This is because `numaflow-go` is a dependency of the Numaflow platform, i.e. the files
in these directories are imported and used by Numaflow. Thus, get the commit SHA
of the merged PR from the previous step, and in the Numaflow repo run:
```shell
go get github.com/numaproj/numaflow-go@<commit-sha>
Expand All @@ -42,8 +44,7 @@ of the merged PR from the previous step, and in the Numaflow repo run:
```shell
go mod tidy
```
Create a PR for these changes. This is necessary as `numaflow-go` is a dependency of the Numaflow platform and the files
in these directories are imported and used by Numaflow.
Create a PR for these changes.

### Adding a New Example

Expand Down
1 change: 0 additions & 1 deletion releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ in the root directory of the Numaflow repo should be updated
go mod tidy
```
Create a PR for these changes.

- If you set the SDK release as pre-release, in your Numaflow repo run:
```shell
go get github.com/numaproj/numaflow-go@<commit-sha>
Expand Down

0 comments on commit 4819050

Please sign in to comment.