fix(glow): handle inline /* ... */ comment

[maurice]

Fixes #463

Please shout if there is anything you are unhappy with.

[nobkd]

Great work so far!

I added if (comment) endComment() to line 270 in glow.js, so the comment gets closed, at the end of the lines even if there is no closing end (or no "block" closing end, to be specific).

In the following example, even though no code is truncated (with the above addition), the end is still a comment, because the closing was "inline" vs the opening was "block":

Try:

/*
hello
*/ world

Do you have a simple fix idea?

(Btw. there are still the other multiline comment types, (e.g. <!-- hello --> world) that also need an inline variant.

I guess, this grows a bit in complexity...

I'm not sure, how to solve this, but you can try giving it a stab, if you'd like :)

[maurice]

Great work so far!

Thanks for the encouragement 😊

In the following example, even though no code is truncated (with the above addition), the end is still a comment, because the closing was "inline" vs the opening was "block":

Good test case 👍

(Btw. there are still the other multiline comment types, (e.g. <!-- hello --> world) that also need an inline variant.

Yeah that's true, and we should be able to use the same technique for all really.

I'm not sure, how to solve this, but you can try giving it a stab, if you'd like :)

I've updated the PR to handle your example (but not the other multiline comment types). I've tried to be sympathetic to the original implementation, but given the assumptions that were made originally (specifically, it's a line-by-line transformation, and each line is assumed to be either a comment or not), it's a bit hacky.

I'm not expecting this to be merged as-is, but we could talk about where to go from here.

I'm a bit concerned about making more significant changes because of the ultra minimal test suite, and there are definitely some lines I can comment-out and no tests fail 😟