Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert .options lists to tables #449

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Jan 21, 2025

fixes #448

I first wanted to wrap the elements in the lists with spans, but I didn't get it to work with inline markdown tags. (werent parsed in lists, etc.).

Therefore, I decided to use short table syntax instead, as it already splits the name and description apart.

Probably, the styling can be done better, but I just tried to imitate the old visuals for now. Feel free to change it to your liking.

before after
grafik grafik

Note: Link test still fails because of broken links, JS bun tests still fail because of bun create dir {recursive: true} failing on existing dirs, should be fixed in a few days I hope. Building nue projects stilll should work fine.

@nobkd nobkd requested a review from tipiirai January 21, 2025 01:26
@tipiirai tipiirai merged commit eb9b263 into nuejs:master Jan 21, 2025
1 of 2 checks passed
@nobkd nobkd deleted the fix/options-layout branch January 21, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: multiple elements in [.options] text break text flow
2 participants