Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): site + example publish #410

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Nov 17, 2024

This is still very much WIP, and completely untested.
I'll try working more on this, sometime next week.

@nobkd nobkd force-pushed the feat-action/web-publish branch 5 times, most recently from 6d088f3 to 559cd92 Compare November 21, 2024 18:09
@nobkd

This comment has been minimized.

@nobkd nobkd force-pushed the feat-action/web-publish branch 11 times, most recently from 9c45e52 to e33d83c Compare November 30, 2024 01:01
@nobkd

This comment was marked as outdated.

@nobkd nobkd force-pushed the feat-action/web-publish branch 3 times, most recently from be5a7c8 to d4cc954 Compare December 6, 2024 15:35
@nobkd

This comment was marked as outdated.

@nobkd nobkd force-pushed the feat-action/web-publish branch 2 times, most recently from b9b1642 to 13f2614 Compare December 14, 2024 23:56
@nobkd nobkd force-pushed the feat-action/web-publish branch from 65cd838 to 7521619 Compare January 17, 2025 17:08
@nobkd nobkd marked this pull request as ready for review January 17, 2025 21:58
@nobkd

This comment was marked as outdated.

@nobkd nobkd marked this pull request as draft January 18, 2025 05:01
@nobkd nobkd marked this pull request as ready for review January 18, 2025 17:41
@nobkd nobkd marked this pull request as draft January 18, 2025 18:19
@nobkd nobkd marked this pull request as ready for review January 18, 2025 18:55
@nobkd
Copy link
Collaborator Author

nobkd commented Jan 19, 2025

Note: I changed the archive name to source.tar.gz instead of using <dirname>.tar.gz. Currently the action generates both versions for compatibility.

I can also undo the change, to keep using the dir name variant. It doesn't really matter, but having the same file name for each example would be more expected I think.

Even after merging this, it is a change of one word (see create.js), so we can change it back before the next release, if we change our mind.

@nobkd

This comment has been minimized.

@nobkd nobkd merged commit 5c8ff9a into nuejs:master Jan 20, 2025
0 of 4 checks passed
@nobkd nobkd deleted the feat-action/web-publish branch January 20, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants