chore: drop Permalink for for now
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobkd
changed the title
permlink -> permalink)permlink → permalink)
|
Indeed. You are right. Perhaps drop the "Permalink for" part altogether at this point and fix this later. I'm thinking of a bigger project where all major localization-related things are implemented at once. |
nobkd
changed the title
permlink → permalink)Permalink for for now
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minimal typo fix.
But I see a problem with this approach, as the
titleproperty is hard-coded this way.What if I want to create a Website not in English? (I do.) Then the
Permalink for 'x'approach doesn't work anymore.In conclusion, my concern is the localizability.
Tests will run properly again after #162 is merged.