Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows adaptation: Fixed some error points in Windows systems #135

Merged
merged 11 commits into from
Jan 9, 2024
Merged

Windows adaptation: Fixed some error points in Windows systems #135

merged 11 commits into from
Jan 9, 2024

Conversation

caesar1shi
Copy link
Contributor

No description provided.

@tipiirai
Copy link
Contributor

tipiirai commented Jan 3, 2024

Oh gosh. I guess I merged these issues (after a lengthy Christmas break) in the wrong order and this now causes a merge conflict. Can you check again? 🙏 This is super important because I cannot debug Windows issues personally!

@fritx
Copy link
Collaborator

fritx commented Jan 3, 2024 •
edited
Loading

because I cannot debug Windows issues personally!

I've tried to setup Windows CI, here is an WIP preview !

Before git cherry-pick this PR: https://github.com/fritx/nue/actions/runs/7399718947/job/20131776062
After git-cherrypick: https://github.com/fritx/nue/actions/runs/7399792114/job/20132011501

Seems the YAML parse error in site.yaml error gone with this fix.

However, the Windows CI test still got a lot to fix, seems like most of them are just path issues like:

image

See: https://github.com/fritx/nue/actions/runs/7399792114/job/20132011501 @tipiirai

fritx
fritx reviewed Jan 3, 2024
View reviewed changes
packages/nuekit/src/init.js Outdated Show resolved Hide resolved
nobkd
nobkd reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@nobkd nobkd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I would only change some code style, as suggested here and maybe do fs.rm with force as noted by fritx

packages/nuekit/src/site.js Outdated Show resolved Hide resolved
packages/nuekit/src/site.js Outdated Show resolved Hide resolved
packages/nuekit/src/site.js Outdated Show resolved Hide resolved
packages/nuekit/src/site.js Outdated Show resolved Hide resolved
caesarzztt and others added 2 commits January 4, 2024 19:54
fritx
fritx reviewed Jan 4, 2024
View reviewed changes
packages/nuekit/src/init.js Outdated Show resolved Hide resolved
caesarzztt and others added 5 commits January 4, 2024 20:05
nobkd
nobkd reviewed Jan 4, 2024
View reviewed changes
packages/nuekit/src/init.js Outdated Show resolved Hide resolved
@fritx fritx mentioned this pull request Jan 8, 2024
Merged
@tipiirai tipiirai merged commit e8a1f9b into nuejs:master Jan 9, 2024
1 check passed
@tipiirai
Copy link
Contributor

tipiirai commented Jan 9, 2024

Thank you, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritx fritx fritx left review comments

@nobkd nobkd nobkd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caesar1shi @tipiirai @fritx @nobkd