Added support of hrw weighted sort for netmap #23

alexvanin · 2019-05-28T17:56:14Z

This commit proposes to add weights into bucket structure by defining
Node structure which contains node index and weight. This allows to
perform weighted hrw sort in the GetSelection routine. For this purpose
new function AddStrawNode() was added.

added Node structure which contains N and W fields
changed function to support weight distribution during graph operations
fixed existing tests
added tests for weighted operations
recompiled demo fixtures, so demo works correctly with new feature

This commit proposes to add weights into bucket structure by defining Node structure which contains node index and weight. This allows to perform weighted hrw sort in the GetSelection routine. For this purpose new function `AddStrawNode()` was added. - added Node structure with contains `n` and `w` fields - changed function to support weight distribution during graph operations - fixed existing tests

codecov-io · 2019-05-28T18:08:52Z

Codecov Report

❗ No coverage uploaded for pull request base (master@b279016). Click here to learn what that means.
The diff coverage is 73%.

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   27.25%           
=========================================
  Files             ?        5           
  Lines             ?     1871           
  Branches          ?        0           
=========================================
  Hits              ?      510           
  Misses            ?     1333           
  Partials          ?       28

Impacted Files	Coverage Δ
policy_dump.go	`0% <0%> (ø)`
utils.go	`100% <100%> (ø)`
policy.go	`81.81% <71.08%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b279016...594f6e3. Read the comment docs.

policy.go

alexvanin · 2019-05-29T07:40:20Z

I appreciate any ideas for tests with weighted nodes.

policy.go

im-kulikov

LGTM, but I propose to rename N() W() to normal names and add description

im-kulikov

👍 nice job

alexvanin added 8 commits May 28, 2019 18:53

Added tests for straw buckets with weighted hrw sort

565d617

Small fix in straw bucket test

0a30bf6

Fixed comments, GetNodesByOption signature and tests

24a5829

Node's fields are now public

98850b5

Recompiled demo fixtures

310058b

Fixed debug skips and comment formatting

9ff8055

Fixed linters errors

65f12b1