services: improve Notary service locking #4093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
optimize-notary
branch
from
4e912a9 to
67c304b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4093 +/- ##
==========================================
- Coverage 83.51% 83.50% -0.02%
==========================================
Files 351 351
Lines 42390 42401 +11
==========================================
+ Hits 35401 35405 +4
- Misses 5251 5268 +17
+ Partials 1738 1728 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
You can only do this for a part of the work (like verifying witnesses), but ultimately there is a shared structure to update, so this can be skipped for now. |
roman-khimov
approved these changes
Nov 22, 2025
Member
|
govet, btw. |
AnnaShaleva
force-pushed
the
optimize-notary
branch
from
67c304b to
4a28052
Compare
AnnaShaleva
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 25, 2025
Fetch nspcc-dev/neo-go#4093. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
1. Allow parallel handling of notary requests with different main transaction. 2. Move expired request removal to PostBlock. Close #4077. Signed-off-by: Anna Shaleva <[email protected]>
It allows to use deferred request lock. No functional changes. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
optimize-notary
branch
from
4a28052 to
bdf2c2b
Compare
roman-khimov
approved these changes
Nov 26, 2025
AnnaShaleva
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 26, 2025
Fetch nspcc-dev/neo-go#4093. Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4077.
Allow parallel witness verification for requests with the same main transaction.@roman-khimov, please, check out the comments in code, the third issue is contraversial, I'm not sure how to safely do that.