Skip to content

fix vendor import get ignored #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2017
Merged

fix vendor import get ignored #485

merged 2 commits into from
Dec 17, 2017

Conversation

Contextualist
Copy link
Contributor

I'm not sure if it should be fixed this way, but the issue is probably real. Gocode handles vendor package content correctly (i.e. the exported fields of a vendor package are all shown), but it seems to ignore vendor import. To reproduce the issue:

$GOPATH/src/github.com/a/b/
|---main.go
|---vendor/github.com/c/d/
    |---p.go

Where in main.go (# denotes the cursor position)

package main

import "github.com/c#"

The option github.com/c/d does not present in the candidates.

@nsf
Copy link
Owner

nsf commented Dec 17, 2017

Merged as is. I don't use that feature, hence have no opinion on its correctness (weird stance frrom the point of view of a maintainer, but whateverr). Patch looks somewhat innocent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants