Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some space between social logo #123

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

EduWTR
Copy link
Contributor

@EduWTR EduWTR commented Apr 3, 2024

Descripcion ✏️

Noee! que te parece un poco de aire entre los logos?

Cambios visuales 🎨

Produ:
image
Local desk:
image

image
Local celu:
image

Como testear? 🐛

Important

Checklist a modo recordatorio. Tildar lo que corresponda

  • Te agregaste como contribuidor/a, en el archivo mdx que tocaste?
  • Si tocaste código (no archivos db), agregaste test para cubrirlo?

Copy link

vercel bot commented Apr 3, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @nsdonato on Vercel.

@nsdonato first needs to authorize it.

@nsdonato
Copy link
Owner

nsdonato commented Apr 4, 2024

Creo que es demasiada separación, al menos en desktop no queda bien.
En mobile no queda mal, pero recién me doy cuenta que también las redes quedaron super pegadas a lxs contribuidorxs.

Entonces, te parece si:

  • Dejar destkop como está
  • Mobile ok, pero con menos espacio
  • Agregar un margin bottom para separarlo de los contribuidores

@EduWTR
Copy link
Contributor Author

EduWTR commented Apr 5, 2024

Commit [f01428d]
[?] Dejar destkop como está ( le puse un max width más justo, pero nusé quitar el justify)
[x] Mobile ok, pero con menos espacio ( le bajé el max-width)
[x] Agregar un margin bottom para separarlo de los contribuidores ( subí el mb a 6 )

Desk:
image
Mobile:
image

@nsdonato nsdonato merged commit 0683367 into nsdonato:main Apr 11, 2024
1 of 2 checks passed
@EduWTR EduWTR deleted the space-between-social-logos branch April 11, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants