feat(misc): remove generation of target defaults for atomized e2e tasks #30730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 0c1f31a.
☁️ Nx Cloud last updated this comment at |
leosvelperez
force-pushed
the
misc/remove-e2e-ci-target-default
branch
from
52522b0 to
3822e18
Compare
leosvelperez
force-pushed
the
misc/remove-e2e-ci-target-default
branch
from
3822e18 to
087e5f9
Compare
leosvelperez
force-pushed
the
misc/remove-e2e-ci-target-default
branch
from
087e5f9 to
0c1f31a
Compare
Coly010
approved these changes
Apr 15, 2025
leosvelperez
force-pushed
the
misc/remove-e2e-ci-target-default
branch
from
0c1f31a to
e812806
Compare
FrozenPandaz
approved these changes
Apr 16, 2025
isaacplmann
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
A target default (
dependsOn: [^build]) for atomized e2e tasks is always generated to work around a previous limitation where tasks couldn't depend on continuous tasks. That meant we couldn't add the dependency to the app's serve task and had to add it to the build task.With continuous tasks now working, that limitation no longer exists. We're now able to correctly infer the task dependency on the app's serve task, and therefore, we can and need to remove the generation of
dependsOn: [^build]in target defaults so it doesn't override what the Cypress and Playwright plugins infers.Expected Behavior
A target default (
dependsOn: [^build]) for atomized e2e tasks should not be generated. Instead, the Cypress and Playwright plugins will infer the correctdependsOnfor the task(s) run in the configured web server command.Related Issue(s)
Fixes #