docs(core): add terminal-ui recipe #30693
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> An RFC about this feature is happening here: #29025. This has the most information about this feature. <!-- This is the behavior we have today --> Nx currently does not explicitly handle tasks which run continuously until they are terminated. <!-- This is the behavior we should expect with the changes in this PR --> This PR adds the initial support for continuous tasks which run continuously until they are terminated. This adds the ability to depend on continuous tasks. There is some more work to be done but this will be enough as an MVP. <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
## Current Behavior When `serve, dev, start` targets are inferred by the `@nx/remix` plugin, they are not inferring `continuous`. ## Expected Behavior When `NX_CONTINUOUS_TASKS_PREVIEW` env var exists, infer the `continuous` property.
## Current Behavior The `@nx/js` plugin exposes a helper to generate `build-deps` and `watch-deps` tasks for inference plugins. It does not currently infer `continuous` for the `watch-deps` task. ## Expected Behavior Ensure `watch-deps` is infered with `continuous: true`
## Current Behavior Rspack and Rsbuild Inference Plugins do not infer `continuous` for serve tasks. ## Expected Behavior Correctly infer `continuous` true.
## Current Behavior Webpack Inference Plugin does not currently infer `continuous` for `serve, preview, serve-static` targets. ## Expected Behavior Webpack Inference Plugin correctly infers `continuous: true`
## Current Behavior The `dev`, `serve`, `preview` and `serve-static` targets inferred by the `@nx/vite/plugin` do not infer `continuous:true` indicating to Nx that these tasks are continuous. ## Expected Behavior Infer `continuous: true` for the serve-like targets for Vite.
…-static (#30069) ## Current Behavior The `@nx/storybook/plugin` does not set `continuous:true` for serve-like targets. ## Expected Behavior The plugin should correctly set `continuous: true` for `serve` and `serve-static`.
## Current Behavior Node applications rely on the `@nx/js:node` executor to handle serving. Unfortunately, it can not be determined if existing usage of the executor is used for a continuous or finite task. ## Expected Behavior Generate new node applications with `continuous: true` for their serve targets
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Unit tests are broken after rebase ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Unit tests are passing ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> <!-- This is the behavior we have today --> <!-- This is the behavior we should expect with the changes in this PR --> <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
…#30644) ## Current Behavior Continuous tasks are not set up for React Rspack Module Federation Remote projects. This is important because `--dev-remotes` is no longer supported with Crystal Module Federation usage. ## Expected Behavior Add Continuous Tasks support for React Rspack Module Federation Remote Projects. This replaces the need for `nx serve shell --dev-remotes=remote1`. Instead, the command is simply `nx serve remote1` and continuous tasks means that the `shell:serve` task is executed correctly.
#30645) ## Current Behavior Module Federation Documentation talks about using `--devRemotes` exclusively for serving remote applications that feature teams are working on. With Continuous Tasks this is no longer the case ## Expected Behavior Add section mentioning Continuous Tasks and the change to the `serve` flow
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Continuous tasks are not supported in DTE and there is no good API for Agents to utilize ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> There is an API for agents to utilize to run continuous tasks. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
… task is already running (#30673) ## Current Behavior When a continuous task is already running, parent tasks are not scheduled. ## Expected Behavior When a continuous task is already running, the task orchestrator should schedule the next tasks and release the waiting threads so parent tasks can be scheduled. ## Related Issue(s) Fixes #
…30675) ## Current Behavior When generating `node` projects with an `e2e` project using Jest, we do not supply any method for the node application to actually be started before running the tests. ## Expected Behavior Using Continuous Tasks, have the e2e project dependOn the serve of the `node` project such that it is available for the e2e tests to run against it.
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Shared continuous tasks are not shown as running in the TUI ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> There is a special status for Shared continuous tasks for the TUI where it will say that it is running in a different nx process ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> - When a user presses `ctrl+c` to force kill the TUI/Nx, continuous tasks that are running are not killed, and the terminal can get stuck or leave the cursor hidden - The summary is incomplete and messy ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> - When a user presses `ctrl+c` to force kill the TUI/Nx, continuous tasks that are running are appropriately killed and everything in the user's terminal is restored back to a good state. - The summary looks good and contains the in progress logs for continuous tasks that were killed ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Wasm build is broken. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Wasm build is fixed. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit c86b654.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
force-pushed
the
next-major
branch
4 times, most recently
from
9a4c671 to
cf7cc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.