[nrf noup] boot/zephyrnrf_cleanup: ensure UARTE RX disabled #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround in the UARTE driver which was up to disabling RX was removed in zephyr-rtos v4.0. Since that MCUboot needs to do corresponding action. Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
ensure_uarte_kill_rx
branch
from
de96a27 to
20587e2
Compare
|
nordicjm
reviewed
Sep 2, 2025
| if (nrfy_uarte_event_check(current, NRF_UARTE_EVENT_RXSTARTED)) { | ||
| nrfy_uarte_task_trigger(current, NRF_UARTE_TASK_STOPRX); | ||
| /* Wait up to 100ms for task to stop */ | ||
| for (int i = 0; i < 1000; i++) { |
There was a problem hiding this comment.
heard yesterday there is an deinit driver function in zephyr from @bjarki-andreasen not sure if it does the same as this or different but might be worth a look at
There was a problem hiding this comment.
Yes there is such deinit - API. I expected it will replace this implementation, but not today,
There was a problem hiding this comment.
The API is indeed implemented zephyrproject-rtos/zephyr#93273 can't we just use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround in the UARTE driver which was up to disabling RX was removed in zephyr-rtos v4.0. Since that MCUboot needs to do corresponding action.
note:
Probably patch might improved a bit so it would be applied only for shell's and mcumgr's console UARTE.