Skip to content

fix: bug: profile page only shows user's 10 most recent pack...#2820

Draft
gittihub-jpg wants to merge 1 commit into
npmx-dev:mainfrom
gittihub-jpg:fix/issue-20260530-2817
Draft

fix: bug: profile page only shows user's 10 most recent pack...#2820
gittihub-jpg wants to merge 1 commit into
npmx-dev:mainfrom
gittihub-jpg:fix/issue-20260530-2817

Conversation

@gittihub-jpg
Copy link
Copy Markdown

@gittihub-jpg gittihub-jpg commented May 30, 2026

Closes #2817

🔗 Linked issue

#2817

🧭 Context

The profile page hardcodes a 10-like limit without pagination or visual indicators, obscuring actual engagement data.

📚 Description

Replaced the hardcoded limit with proper pagination support for ATproto feed requests. Implemented infinite scroll on the profile view and added a total count indicator to the likes component.

📝 Special notes

  • server/api/social/profile/[identifier]/likes.get.ts — Removed hardcoded limit, added pagination parameters
  • app/utils/atproto/likes.ts — Updated to handle paginated ATproto requests
  • app/pages/profile/[identity]/index.vue — Added infinite scroll implementation
  • app/components/Package/Likes.vue — Rendered full list with total count indicator

Before creating the pull request, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way. If you find a duplicate, please close this PR and comment on the other one.
  • Check backwards compatibility

Fixes npmx-dev#2817

Signed-off-by: gittihub-jpg <rico@springer-mail.net>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment May 30, 2026 10:53pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview May 30, 2026 10:53pm
npmx-lunaria Ignored Ignored May 30, 2026 10:53pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dfc3b735-1194-4336-9661-f1b27d7a231c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @gittihub-jpg! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

❌ Patch coverage is 42.30769% with 30 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/profile/[identity]/index.vue 35.71% 21 Missing and 6 partials ⚠️
app/utils/atproto/likes.ts 66.66% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@serhalp
Copy link
Copy Markdown
Member

serhalp commented May 30, 2026

👋🏼 Hello @gittihub-jpg! Thank you for the PR. May I ask if you've familiarized yourself with our policy?

@serhalp serhalp added the 007 This PR *may* not follow our code of conduct regarding AI usage. label May 30, 2026
@gittihub-jpg
Copy link
Copy Markdown
Author

gittihub-jpg commented May 31, 2026

Hi, I take it your referring to the misconfigured description.
I haven’t seen the policy of mentioning a tomato?
I finished at like 2 am and it seems like it didn’t fill out my template correctly, it really looks like an llm but it was just me sleep deprived. If you want I can fix the failures and body or you will unfortunately close the request I would guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

007 This PR *may* not follow our code of conduct regarding AI usage.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: profile page only shows user's 10 most recent package likes

2 participants