feat: update team list and design on about page#2756
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a 'core' contributor role and backend handling; introduces a new GovernanceList component; refactors about.vue to group governance (steward+core), maintainers, and contributors and to use the component; updates i18n/schema and many locale keys; harmonises avatar/logo styling; and adds accessibility tests for the new component. ChangesGovernance Role and Component Extraction
Sequence Diagram(s): Possibly related PRs:
Suggested reviewers:
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/About/GovernanceList.vue`:
- Around line 8-14: The roleLabels computed property is missing a translated
label for the "core" Role, causing it to fall back to raw text; update the
object inside the roleLabels computed (the mapping that currently contains
steward and maintainer) to include core: $t('about.team.role_core'), and also
add the key about.team.role_core to your locale files and schema so the
translation is available for all locales.
In `@server/api/contributors.get.ts`:
- Around line 114-117: The role rank values are inverted relative to the
ascending final sort; update the numeric orders returned in the role-resolution
block so higher-precedence roles get smaller numbers for an ascending sort
(e.g., change teams.steward -> order: 0, teams.core -> order: 1,
teams.maintainer -> order: 2, and default contributor -> order: 3) by editing
the return objects in the function that resolves roles (the lines returning {
role: 'steward', order: ... }, { role: 'core', order: ... }, { role:
'maintainer', order: ... }, and the final default).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0ce381e3-6ef4-4678-ba0d-cb1d46aaf3be
📒 Files selected for processing (8)
app/components/About/GovernanceList.vueapp/components/About/LogoList.vueapp/pages/about.vueapp/pages/pds.vuei18n/locales/en.jsoni18n/schema.jsonserver/api/contributors.get.tstest/nuxt/a11y.spec.ts
There was a problem hiding this comment.
🧹 Nitpick comments (1)
server/api/contributors.get.ts (1)
173-173: ⚡ Quick winUpdate stale role-group comment to match current filter logic.
Line 173 says “stewards + maintainers”, but Line 176 now includes
coreas well. Please update the comment to avoid future confusion when reading sponsor-eligibility logic.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@server/api/contributors.get.ts` at line 173, Update the stale inline comment that currently reads “stewards + maintainers” to accurately reflect the active filter logic by including the `core` group (e.g., “stewards, core, and maintainers”) near the sponsor-eligibility block in server/api/contributors.get.ts where the `core` group is now part of the filter; keep wording concise and aligned with the surrounding sponsor-eligibility logic so future readers aren’t confused.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@server/api/contributors.get.ts`:
- Line 173: Update the stale inline comment that currently reads “stewards +
maintainers” to accurately reflect the active filter logic by including the
`core` group (e.g., “stewards, core, and maintainers”) near the
sponsor-eligibility block in server/api/contributors.get.ts where the `core`
group is now part of the filter; keep wording concise and aligned with the
surrounding sponsor-eligibility logic so future readers aren’t confused.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e039c2d8-4049-4256-ac43-e54d961737c6
📒 Files selected for processing (4)
app/components/About/GovernanceList.vuei18n/locales/en.jsoni18n/schema.jsonserver/api/contributors.get.ts
✅ Files skipped from review due to trivial changes (1)
- i18n/locales/en.json
🚧 Files skipped from review as they are similar to previous changes (2)
- i18n/schema.json
- app/components/About/GovernanceList.vue
ghostdevv
left a comment
ghostdevv
left a comment
There was a problem hiding this comment.
Not sure that "Governance" is the right word for stewards/core as it encompasses all the groups incl maintainers - we could write just "Core" as the title, and keep daniel/matias with the "steward" on their card
|
@ghostdevv Thanks, good point, done |
ghostdevv
force-pushed
the
feat/governance
branch
from
e7a8ddd to
6e16084
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
i18n/locales/ja-JP.json (1)
1186-1191:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd the new team keys required by the governance split.
The Japanese locale is missing the new
about.teamkeys consumed by the updated UI (core,maintainers,role_core), so JP users will get fallback text for those labels.Suggested fix
"team": { "title": "チーム", + "core": "ガバナンス", + "maintainers": "メンテナ", + "role_core": "コア", "role_steward": "スチュワード", "role_maintainer": "メンテナ", "sponsor": "スポンサー", "sponsor_aria": "GitHubで {name} さんをスポンサーする" },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@i18n/locales/ja-JP.json` around lines 1186 - 1191, The ja-JP locale is missing the new about.team keys used by the UI; add the keys "about.team.core", "about.team.maintainers", and "about.team.role_core" to the existing team block in i18n/locales/ja-JP.json (near the existing "title", "role_steward", "role_maintainer", "sponsor" entries) with appropriate Japanese translations so the UI no longer falls back to another locale.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/storybook/mocks/handlers.ts`:
- Around line 31-39: The mock contributor object with login 'mock-core-a' reuses
id: 1002 (which collides with 'mock-steward-b'); update the id on the
'mock-core-a' object in handlers.ts to a unique value (for example 1003 or any
unused id) and ensure any tests or fixtures that reference that id are updated
accordingly so consumers that key by id won't de-duplicate entries.
---
Outside diff comments:
In `@i18n/locales/ja-JP.json`:
- Around line 1186-1191: The ja-JP locale is missing the new about.team keys
used by the UI; add the keys "about.team.core", "about.team.maintainers", and
"about.team.role_core" to the existing team block in i18n/locales/ja-JP.json
(near the existing "title", "role_steward", "role_maintainer", "sponsor"
entries) with appropriate Japanese translations so the UI no longer falls back
to another locale.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1ba531bf-ea45-4225-aa9e-c4630f956302
📒 Files selected for processing (12)
app/storybook/mocks/handlers.tsi18n/locales/bn-IN.jsoni18n/locales/en.jsoni18n/locales/es.jsoni18n/locales/ja-JP.jsoni18n/locales/nl.jsoni18n/locales/ro-RO.jsoni18n/locales/tr-TR.jsoni18n/locales/zh-CN.jsoni18n/locales/zh-TW.jsoni18n/schema.jsontest/nuxt/a11y.spec.ts
💤 Files with no reviewable changes (1)
- i18n/locales/bn-IN.json
🚧 Files skipped from review as they are similar to previous changes (9)
- i18n/locales/zh-CN.json
- i18n/locales/zh-TW.json
- i18n/locales/en.json
- i18n/locales/es.json
- i18n/locales/tr-TR.json
- i18n/locales/nl.json
- i18n/locales/ro-RO.json
- test/nuxt/a11y.spec.ts
- i18n/schema.json
ghostdevv
changed the title
2 participants
📚 Description
Since we added a separate core role, there are multiple roles in one group now. Divided it into two groups and updated the cards and contributors style to make everything more streamlined and neat
Screenshot