Skip to content

fix: dialog title switch with select #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 5 commits into from
Feb 14, 2026
Merged

fix: dialog title switch with select #1497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0d5404
fix: dialog title switch with select
zzxming Feb 14, 2026
46d9401
Merge remote-tracking branch 'origin/main' into fix-dialog-title
ghostdevv Feb 14, 2026
5558bc6
fix: use package.trends.items.downloads
ghostdevv Feb 14, 2026
3f57a3d
fix: use $t
ghostdevv Feb 14, 2026
9db3676
chore: remove unused translation
ghostdevv Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/components/Package/WeeklyDownloadStats.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ const route = useRoute()
const chartModal = useModal('chart-modal')
const hasChartModalTransitioned = shallowRef(false)

const modalTitle = computed(() => {
const facet = route.query.facet as string | undefined
if (facet === 'likes') return $t('package.trends.items.likes')
if (facet === 'contributors') return $t('package.trends.items.contributors')
return $t('package.trends.items.downloads')
})

const isChartModalOpen = shallowRef<boolean>(false)

function handleModalClose() {
Expand Down Expand Up @@ -305,7 +312,7 @@ const config = computed(() => {

<PackageChartModal
v-if="isChartModalOpen && hasWeeklyDownloads"
:title="$t('package.downloads.modal_title')"
:title="modalTitle"
@close="handleModalClose"
@transitioned="handleModalTransitioned"
>
Expand Down Expand Up @@ -356,6 +363,7 @@ const config = computed(() => {
padding: 0 !important;
letter-spacing: 0.04rem;
}

.vue-ui-sparkline text {
font-family:
Geist Mono,
Expand Down
1 change: 0 additions & 1 deletion i18n/locales/ar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,6 @@
},
"downloads": {
"title": "التنزيلات الأسبوعية",
"modal_title": "التنزيلات الأسبوعية",
"analyze": "تحليل التنزيلات",
"community_distribution": "عرض توزيع تبنّي المجتمع"
},
Expand Down
1 change: 0 additions & 1 deletion i18n/locales/bg-BG.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@
},
"downloads": {
"title": "Седмични изтегляния",
"modal_title": "Седмични изтегляния",
"analyze": "Анализ на изтеглянията",
"community_distribution": "Преглед на разпределението на приемането от общността"
},
Expand Down
1 change: 0 additions & 1 deletion i18n/locales/de-DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,6 @@
},
"downloads": {
"title": "Wöchentliche Downloads",
"modal_title": "Wöchentliche Downloads",
"analyze": "Downloads analysieren",
"community_distribution": "Community-Adoptionsverteilung ansehen"
},
Expand Down
1 change: 0 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,6 @@
},
"downloads": {
"title": "Weekly Downloads",
"modal_title": "Weekly Downloads",
"analyze": "Analyze downloads",
"community_distribution": "View community adoption distribution"
},
Expand Down
1 change: 0 additions & 1 deletion i18n/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,6 @@
},
"downloads": {
"title": "Descargas Semanales",
"modal_title": "Descargas semanales",
"analyze": "Analizar descargas",
"community_distribution": "Ver distribución de adopción comunitaria"
},
Expand Down
1 change: 0 additions & 1 deletion i18n/locales/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,6 @@
},
"downloads": {
"title": "Téléchargements hebdo.",
"modal_title": "Téléchargements hebdomadaires",
"analyze": "Analyser les téléchargements",
"community_distribution": "Voir la distribution des versions téléchargées par la communauté"
},
Expand Down
1 change: 0 additions & 1 deletion i18n/locales/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,6 @@
},
"downloads": {
"title": "週間ダウンロード数",
"modal_title": "週間ダウンロード数",
"analyze": "ダウンロード数を分析",
"community_distribution": "コミュニティの採用分布を表示"
},
Expand Down
3 changes: 1 addition & 2 deletions i18n/locales/pl-PL.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,7 @@
"downloads": {
"title": "Pobrania tygodniowe",
"analyze": "Analizuj pobrania",
"community_distribution": "Zobacz, jak społeczność korzysta z pakietu",
"modal_title": "Pobrania tygodniowe"
"community_distribution": "Zobacz, jak społeczność korzysta z pakietu"
},
"install_scripts": {
"title": "Skrypty instalacji",
Expand Down
1 change: 0 additions & 1 deletion i18n/locales/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,6 @@
},
"downloads": {
"title": "每周下载量",
"modal_title": "每周下载量",
"analyze": "分析下载量",
"community_distribution": "查看社区采用分布"
},
Expand Down
3 changes: 0 additions & 3 deletions i18n/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,9 +1117,6 @@
"title": {
"type": "string"
},
"modal_title": {
"type": "string"
},
"analyze": {
"type": "string"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/ar-EG.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@
},
"downloads": {
"title": "التنزيلات الأسبوعية",
"modal_title": "التنزيلات الأسبوعية",
"analyze": "تحليل التنزيلات",
"community_distribution": "عرض توزيع تبنّي المجتمع"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/bg-BG.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@
},
"downloads": {
"title": "Седмични изтегляния",
"modal_title": "Седмични изтегляния",
"analyze": "Анализ на изтеглянията",
"community_distribution": "Преглед на разпределението на приемането от общността"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/de-DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@
},
"downloads": {
"title": "Wöchentliche Downloads",
"modal_title": "Wöchentliche Downloads",
"analyze": "Downloads analysieren",
"community_distribution": "Community-Adoptionsverteilung ansehen"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/en-GB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@
},
"downloads": {
"title": "Weekly Downloads",
"modal_title": "Weekly Downloads",
"analyze": "Analyze downloads",
"community_distribution": "View community adoption distribution"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@
},
"downloads": {
"title": "Weekly Downloads",
"modal_title": "Weekly Downloads",
"analyze": "Analyze downloads",
"community_distribution": "View community adoption distribution"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/es-419.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,6 @@
},
"downloads": {
"title": "Descargas Semanales",
"modal_title": "Descargas semanales",
"analyze": "Analizar descargas",
"community_distribution": "Ver distribución de adopción comunitaria"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/es-ES.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,6 @@
},
"downloads": {
"title": "Descargas Semanales",
"modal_title": "Descargas semanales",
"analyze": "Analizar descargas",
"community_distribution": "Ver distribución de adopción comunitaria"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@
},
"downloads": {
"title": "Téléchargements hebdo.",
"modal_title": "Téléchargements hebdomadaires",
"analyze": "Analyser les téléchargements",
"community_distribution": "Voir la distribution des versions téléchargées par la communauté"
},
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,6 @@
},
"downloads": {
"title": "週間ダウンロード数",
"modal_title": "週間ダウンロード数",
"analyze": "ダウンロード数を分析",
"community_distribution": "コミュニティの採用分布を表示"
},
Expand Down
3 changes: 1 addition & 2 deletions lunaria/files/pl-PL.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,7 @@
"downloads": {
"title": "Pobrania tygodniowe",
"analyze": "Analizuj pobrania",
"community_distribution": "Zobacz, jak społeczność korzysta z pakietu",
"modal_title": "Pobrania tygodniowe"
"community_distribution": "Zobacz, jak społeczność korzysta z pakietu"
},
"install_scripts": {
"title": "Skrypty instalacji",
Expand Down
1 change: 0 additions & 1 deletion lunaria/files/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@
},
"downloads": {
"title": "每周下载量",
"modal_title": "每周下载量",
"analyze": "分析下载量",
"community_distribution": "查看社区采用分布"
},
Expand Down
Loading