Skip to content

chore: remove vacations from lunaria and compare logic #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Feb 12, 2026
+7 −72
Merged

chore: remove vacations from lunaria and compare logic #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions lunaria/files/en-GB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,40 +1109,5 @@
"p1": "If you encounter an accessibility barrier on {app}, please let us know by opening an issue on our {link}. We take these reports seriously and will do our best to address them.",
"link": "GitHub repository"
}
},
"vacations": {
"title": "on vacation",
"meta_description": "The npmx team is recharging. Discord reopens in a week.",
"heading": "recharging",
"subtitle": "we've been building npmx at a pace that has cost {some} of us sleep. we don't want that to be the norm! so we are taking a week off. together.",
"illustration_alt": "a single row of cosy icons",
"poke_log": "Poke the campfire",
"what": {
"title": "what's happening",
"p1": "discord is closed {dates}.",
"dates": "February 14 – 21",
"p2": "all invite links are gone and channels are locked – except {garden}, which stays open for folks who want to keep hanging out.",
"garden": "#garden"
},
"meantime": {
"title": "in the meantime",
"p1": "{site} and {repo} stay open – dig in, file issues, open PRs. we'll get to everything when we're back. just don't expect a fast review. we'll be somewhere near a cosy fireplace.",
"repo_link": "the repo"
},
"return": {
"title": "see you soon",
"p1": "we'll come back recharged and ready for the final push to March 3rd. {social} for updates.",
"social_link": "follow us on Bluesky",
"add_to_calendar": "remind me when Discord reopens"
},
"stats": {
"contributors": "Contributors",
"commits": "Commits",
"pr": "PRs Merged",
"subtitle": {
"some": "some",
"all": "all"
}
}
}
}
35 changes: 0 additions & 35 deletions lunaria/files/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,40 +1109,5 @@
"p1": "If you encounter an accessibility barrier on {app}, please let us know by opening an issue on our {link}. We take these reports seriously and will do our best to address them.",
"link": "GitHub repository"
}
},
"vacations": {
"title": "on vacation",
"meta_description": "The npmx team is recharging. Discord reopens in a week.",
"heading": "recharging",
"subtitle": "we've been building npmx at a pace that has cost {some} of us sleep. we don't want that to be the norm! so we are taking a week off. together.",
"illustration_alt": "a single row of cosy icons",
"poke_log": "Poke the campfire",
"what": {
"title": "what's happening",
"p1": "discord is closed {dates}.",
"dates": "February 14 – 21",
"p2": "all invite links are gone and channels are locked – except {garden}, which stays open for folks who want to keep hanging out.",
"garden": "#garden"
},
"meantime": {
"title": "in the meantime",
"p1": "{site} and {repo} stay open – dig in, file issues, open PRs. we'll get to everything when we're back. just don't expect a fast review. we'll be somewhere near a cosy fireplace.",
"repo_link": "the repo"
},
"return": {
"title": "see you soon",
"p1": "we'll come back recharged and ready for the final push to March 3rd. {social} for updates.",
"social_link": "follow us on Bluesky",
"add_to_calendar": "remind me when Discord reopens"
},
"stats": {
"contributors": "Contributors",
"commits": "Commits",
"pr": "PRs Merged",
"subtitle": {
"some": "some",
"all": "all"
}
}
}
}
6 changes: 4 additions & 2 deletions lunaria/prepare-json-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,11 @@ export async function mergeLocaleObject(locale: LocaleObject): Promise<NestedObj

async function loadLocaleSourceJson<T = unknown>(name: string): Promise<T> {
const rawJson = JSON.parse(await fs.readFile(path.resolve(`${localesFolder}/${name}`), 'utf8'))
// Exclude $schema since it isn't useful in generated files and the relative path
// Exclude $schema since it isn't useful in generated files and the relative

// TODO: removing vacations entry key for temporal recharging page
// would be wrong anyway
const { $schema: _, ...rest } = rawJson
const { $schema: _, vacations: __, ...rest } = rawJson
return rest
}

Expand Down
3 changes: 3 additions & 0 deletions scripts/compare-translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@ const run = async (): Promise<void> => {
lang: 'en',
})

// TODO: removing vacations entry key for temporal recharging page
delete referenceContent.vacations

// $schema is a JSON Schema reference, not a translation key
delete referenceContent.$schema

Expand Down
Loading