Skip to content

Conversation

@RYGRIT
Copy link
Contributor

@RYGRIT RYGRIT commented Feb 12, 2026

this pr:

  • add zh-CN translations to missing entries
  • Updated CONTRIBUTING.md to correctly state that settings are stored in localStorage instead of cookies.
missing entries:
  • common.or
  • package.security_downgrade.title
  • package.security_downgrade.description_to_none_provenance
  • package.security_downgrade.description_to_none_trustedPublisher
  • package.security_downgrade.description_to_provenance_trustedPublisher
  • package.security_downgrade.fallback_install_provenance
  • package.security_downgrade.fallback_install_trustedPublisher
  • package.security_downgrade.provenance_link_text
  • package.security_downgrade.trusted_publishing_link_text
  • package.versions.distribution_title
  • package.versions.distribution_modal_title
  • package.versions.grouping_major
  • package.versions.grouping_minor
  • package.versions.recent_versions_only
  • package.versions.recent_versions_only_tooltip
  • package.versions.show_low_usage
  • package.versions.show_low_usage_tooltip
  • package.versions.date_range_tooltip
  • package.trends.facet
  • package.trends.title
  • package.trends.items.likes
  • package.downloads.modal_title
  • package.vulnerabilities.fixed_in_title
  • connector.modal.auto_open_url
  • operations.queue.retry_web_auth
  • operations.queue.open_web_auth
  • compare.facets.trends.title
  • a11y.title
  • a11y.footer_title
  • a11y.welcome
  • a11y.approach.title
  • a11y.approach.p1
  • a11y.approach.p2
  • a11y.approach.about_link
  • a11y.measures.title
  • a11y.measures.p1
  • a11y.measures.li1
  • a11y.measures.li2
  • a11y.measures.li3
  • a11y.measures.li4
  • a11y.measures.li5
  • a11y.measures.li6
  • a11y.limitations.title
  • a11y.limitations.p1
  • a11y.contact.title
  • a11y.contact.p1
  • a11y.contact.link

I need to review:

  • account_menu.ops
  • a11y.measures.li4

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 12, 2026 5:07am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 12, 2026 5:07am
npmx-lunaria Ignored Ignored Feb 12, 2026 5:07am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

This pull request updates CONTRIBUTING.md to change the locale persistence note from cookies to localStorage and adjusts related i18n/localization guidance. It also changes Chinese locale files (i18n/locales/zh-CN.json and lunaria/files/zh-CN.json), adding a top-level a11y group, introducing a security_downgrade structure, new keys for trends, downloads, vulnerabilities and operations.queue/connector.modal web-auth flows, and refining many existing package-related translations (likes, readme, account_menu, etc.).

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, detailing zh-CN translation additions and a CONTRIBUTING.md update about localStorage.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
lunaria/files/zh-CN.json (1)

354-356: Minor terminology inconsistency with "likes" translation.

items.likes uses "喜欢" here, but elsewhere in the file:

  • package.likes.like (line 212) uses "点赞此包"
  • compare.facets.items.totalLikes.label (line 953) uses "点赞数"

Consider using "点赞" consistently for the "likes" concept across the file, as it's the more common term for social media-style likes in Chinese. However, this is a minor stylistic choice and acceptable as-is if intentional.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@RYGRIT RYGRIT marked this pull request as draft February 12, 2026 04:05
@danielroe danielroe changed the title chore(i18n): add zh-CN translations to entries that lack translations fix(i18n): add zh-CN translations to entries that lack translations Feb 12, 2026
@danielroe danielroe added this pull request to the merge queue Feb 12, 2026
Merged via the queue into npmx-dev:main with commit 391a327 Feb 12, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants