fix: uses ci-friendly startsWith instead of fromJSON #531
Conversation
owlstronaut
force-pushed
the
owlstronaut/ci-fix
branch
from
d3f4bb4 to
747f8b7
Compare
|
@wraithgar I wasn't able to validate this bit until testing in the real CI. I didn't want to be specific about v24, but think we have to here. Also there is a specific time in v22 that --test-timeout was added, so we can't include that in the base testing either - but we get that with the v24. I think that is okay here until we run into it and have to solve it. npm/abbrev-js#108 the real CI here is passing short of needing this template change |
|
|
|
It may also be time to think about being more explicit with test timeouts. Tests that need the large timeout can have it set and we can be more aware of where those are needed? |
I mean yes and no, the backporting doesn't line up perfectly with these older versions being tested in various cli repos. There is also this issue for v22 nodejs/node#57672 (comment). |
🤖 I have created a release *beep* *boop* --- ## [4.26.1](v4.26.0...v4.26.1) (2025-10-20) ### Bug Fixes * [`eeb4266`](eeb4266) [#531](#531) uses ci-friendly startsWith instead of fromJSON (#531) (@owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
No description provided.