This repository was archived by the owner on Feb 15, 2022. It is now read-only.
Update read-package-json, setup GitHub action #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hosted-git-infowhich is a transitive dependency ofread-package-jsonhas the following CVE filed against it for versions prior to 3.0.8: https://nvd.nist.gov/vuln/detail/CVE-2021-23362This PR just bumps
read-package-json, which brings it in, to a newer version which brings in a much newer version ofhosted-git-info.I as well added a bare bones GitHub action to run tests. I ran
npm testbefore I did this update, and after, and it failed mostly the same (it seems the tests weren't updated in the past for changes?)Evidence of the action working can be seen on my fork: https://github.com/DarthHater/read-installed/actions/runs/721565318
I can send a separate PR that fixes the tests, and updates them to what they would be now, I'd just want someone to confirm I'm on the right path!
cc @bhamail
We use this project at Sonatype on a couple of our tools, and have always dug it! We've been using
list-installednowadays, but there are still plenty of projects that rely onread-installed, and we'd love to help out when we can :)