Skip to content

Conversation

@nowsprinting
Copy link
Owner

Creating AssemblyInfo.cs files for friend assemblies

Creates an AssemblyInfo.cs file for each assembly to mark Assembly Definition References as Friend assemblies.
This allows access to internal types and members.

Copilot AI review requested due to automatic review settings August 31, 2025 06:38
@github-actions github-actions bot added the enhancement New feature or request label Aug 31, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for creating AssemblyInfo.cs files to configure friend assemblies, enabling access to internal types and members across related assemblies. The implementation generates appropriate InternalsVisibleTo attributes based on the assembly structure.

  • Adds AssemblyInfo.cs file generation with InternalsVisibleTo attributes for friend assemblies
  • Creates comprehensive tests to verify AssemblyInfo.cs file creation and content
  • Updates documentation to reflect the new AssemblyInfo.cs functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Editor/DoCreateScriptFoldersWithTests.cs Implements AssemblyInfo.cs generation logic with friend assembly configurations
Tests/Editor/DoCreateScriptFoldersWithTestsTest.cs Adds tests verifying AssemblyInfo.cs content and InternalsVisibleTo attributes
Tests/Editor/DoCreateScriptFoldersWithTestsTestUnderPackages.cs Adds tests for AssemblyInfo.cs file existence in package scenarios
README.md Updates documentation to describe AssemblyInfo.cs functionality and reorganizes sections
Comments suppressed due to low confidence (1)

Tests/Editor/DoCreateScriptFoldersWithTestsTest.cs:1

  • The test method name is inconsistent with other test methods. It should be Action_CreatedTestsEditorAssemblyInfoWithInternalsVisibleTo to match the pattern used in other test methods and clarify that it's testing the content, not just creation.
// Copyright (c) 2021-2025 Koji Hasegawa.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Code Metrics Report

master (cc96f7c) #67 (3e0cfd0) +/-
Coverage 16.1% 12.8% -3.3%
Code to Test Ratio 1:1.4 1:1.4 -0.1
Test Execution Time 2m44s 2m36s -8s
Details
  |                     | master (cc96f7c) | #67 (3e0cfd0) |  +/-  |
  |---------------------|------------------|---------------|-------|
- | Coverage            |            16.1% |         12.8% | -3.3% |
  |   Files             |                4 |             4 |     0 |
  |   Lines             |              130 |           163 |   +33 |
  |   Covered           |               21 |            21 |     0 |
- | Code to Test Ratio  |            1:1.4 |         1:1.4 |  -0.1 |
  |   Code              |              246 |           295 |   +49 |
+ |   Test              |              363 |           427 |   +64 |
+ | Test Execution Time |            2m44s |         2m36s |   -8s |

Code coverage of files in pull request scope (0.0% → 0.0%)

Files Coverage +/- Status
Editor/DoCreateScriptFoldersWithTests.cs 0.0% 0.0% modified

Reported by octocov

@nowsprinting nowsprinting merged commit 39eb42a into master Aug 31, 2025
14 checks passed
@nowsprinting nowsprinting deleted the feature/friend_asm branch August 31, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants